From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32776) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zi0uk-0003XB-VB for qemu-devel@nongnu.org; Fri, 02 Oct 2015 10:02:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zi0uf-0000iA-Uq for qemu-devel@nongnu.org; Fri, 02 Oct 2015 10:02:22 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:37290) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zi0uf-0000hh-O3 for qemu-devel@nongnu.org; Fri, 02 Oct 2015 10:02:17 -0400 Received: by wicfx3 with SMTP id fx3so32415866wic.0 for ; Fri, 02 Oct 2015 07:02:16 -0700 (PDT) Date: Fri, 2 Oct 2015 16:02:12 +0200 From: Eduardo Otubo Message-ID: <20151002140212.GA25464@vader> References: <1443628758-26038-1-git-send-email-drjones@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ZGiS0Q5IWpPtfppv" Content-Disposition: inline In-Reply-To: <1443628758-26038-1-git-send-email-drjones@redhat.com> Subject: Re: [Qemu-devel] [PATCH] configure: arm/aarch64: allow enable-seccomp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrew Jones Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org --ZGiS0Q5IWpPtfppv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 30, 2015 at 11=3D59=3D18AM -0400, Andrew Jones wrote: > This is a revert of ae6e8ef11e6cb, but with a bit of refactoring, > and also specifically adding arm/aarch64, rather than all > architectures. Currently, libseccomp code appears to also support > mips, ppc, and s390. We could therefore allow qemu to enable > seccomp for those platforms as well, with additional configure > patches, given they're tested and proven to work. >=20 > Signed-off-by: Andrew Jones > --- > Depends on > http://lists.nongnu.org/archive/html/qemu-devel/2015-07/msg00191.html >=20 > configure | 32 +++++++++++++++++++++++++------- > 1 file changed, 25 insertions(+), 7 deletions(-) >=20 > diff --git a/configure b/configure > index f14454e691b36..2d993bf210b56 100755 > --- a/configure > +++ b/configure > @@ -1870,16 +1870,34 @@ fi > # libseccomp check > =20 > if test "$seccomp" !=3D "no" ; then > - if test "$cpu" =3D "i386" || test "$cpu" =3D "x86_64" && > - $pkg_config --atleast-version=3D2.1.1 libseccomp; then > + case "$cpu" in > + i386|x86_64) > + libseccomp_minver=3D"2.1.1" > + ;; > + arm|aarch64) > + libseccomp_minver=3D"2.2.3" > + ;; > + *) > + libseccomp_minver=3D"" > + ;; > + esac > + > + if test "$libseccomp_minver" !=3D "" && > + $pkg_config --atleast-version=3D$libseccomp_minver libseccomp ; t= hen > libs_softmmu=3D"$libs_softmmu `$pkg_config --libs libseccomp`" > QEMU_CFLAGS=3D"$QEMU_CFLAGS `$pkg_config --cflags libseccomp`" > - seccomp=3D"yes" > + seccomp=3D"yes" > else > - if test "$seccomp" =3D "yes"; then > - feature_not_found "libseccomp" "Install libseccomp devel >= =3D 2.1.1" > - fi > - seccomp=3D"no" > + if test "$seccomp" =3D "yes" ; then > + if test "$libseccomp_minver" !=3D "" ; then > + feature_not_found "libseccomp" \ > + "Install libseccomp devel >=3D $libseccomp_minver" > + else > + feature_not_found "libseccomp" \ > + "libseccomp is not supported for host cpu $cpu" > + fi > + fi > + seccomp=3D"no" > fi > fi > ########################################## > --=20 > 2.5.2 >=20 The patch does look good, but I'll just delay a little bit the pull request due to more patches incoming. I just want to create a single batch. Is ok if we just merge it mid or end of next week? Thanks for the contribution. Acked-by: Eduardo Otubo --=20 Eduardo Otubo ProfitBricks GmbH --ZGiS0Q5IWpPtfppv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWDo5kAAoJEP0M/1sS+L0vB28IALc1MS7gOqLLA8nYyRfk9osF QnRbSwPk+XGeUWssmP2F1mQ6pqffhTK+XfNvEe3r0JLpkv/AsbtAq2OFbn0SRFwU 7VuDNhTvbWKoVuOPRd+BFEoh9PFDDrPROxaDjPOqG+rXICRAck/pMXXhEx4brUR2 3arGLFyAaPRU/acAlsasOQKYA76ht+ZTQ00QVvzmcM9Zx4mHs3Gy3lKtd6QJ/KgX /9QLL9uANVcp2ZWAn8lvdomyaEp2gbWvAdwje/NhzFsOy+R9cRxHeXll+hKK83vI cZHbDqxnRHasjt30LyRk2Fv4QDupyp8QAUfvMVsT0ZkZKx1iwtY88BznfDEjcBM= =iTBn -----END PGP SIGNATURE----- --ZGiS0Q5IWpPtfppv--