From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51337)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Zi0X5-0003yF-5t
	for qemu-devel@nongnu.org; Fri, 02 Oct 2015 09:38:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Zi0X1-0004ZQ-RK
	for qemu-devel@nongnu.org; Fri, 02 Oct 2015 09:37:55 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48961)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Zi0X1-0004ZD-Mp
	for qemu-devel@nongnu.org; Fri, 02 Oct 2015 09:37:51 -0400
Date: Fri, 2 Oct 2015 16:37:45 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20151002163639-mutt-send-email-mst@redhat.com>
References: <1443720248-15482-1-git-send-email-marcandre.lureau@redhat.com>
	<1443720248-15482-17-git-send-email-marcandre.lureau@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1443720248-15482-17-git-send-email-marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v7 16/24] vhost user: add rarp sending
 after live migration for legacy guest
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: marcandre.lureau@redhat.com
Cc: haifeng.lin@huawei.com, thibaut.collet@6wind.com, jasowang@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com

On Thu, Oct 01, 2015 at 07:24:00PM +0200, marcandre.lureau@redhat.com wrote:
> diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
> index 840f443..da66b64 100644
> --- a/hw/net/vhost_net.c
> +++ b/hw/net/vhost_net.c
> @@ -388,6 +388,18 @@ void vhost_net_cleanup(struct vhost_net *net)
>      g_free(net);
>  }
>  
> +int vhost_net_notify_migration_done(struct vhost_net *net, char* mac_addr)
> +{
> +    const VhostOps *vhost_ops = net->dev.vhost_ops;
> +    int r = -1;
> +
> +    if (vhost_ops->vhost_migration_done) {
> +        r = vhost_ops->vhost_migration_done(&net->dev, mac_addr);
> +    }
> +
> +    return r;
> +}
> +
>  bool vhost_net_virtqueue_pending(VHostNetState *net, int idx)
>  {
>      return vhost_virtqueue_pending(&net->dev, idx);
> @@ -479,6 +491,11 @@ void vhost_net_virtqueue_mask(VHostNetState *net, VirtIODevice *dev,
>  {
>  }
>  
> +int vhost_net_notify_migration_done(struct vhost_net *net)
> +{
> +    return -1;
> +}
> +
>  VHostNetState *get_vhost_net(NetClientState *nc)
>  {
>      return 0;

This signature does not fit the one above.
How was this tested?