qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Marc-André Lureau" <mlureau@redhat.com>
Cc: haifeng lin <haifeng.lin@huawei.com>,
	thibaut collet <thibaut.collet@6wind.com>,
	jasowang@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com,
	marcandre lureau <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v7 03/24] util: add linux-only memfd fallback
Date: Fri, 2 Oct 2015 17:01:30 +0300	[thread overview]
Message-ID: <20151002170038-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <1726570872.23125054.1443794177275.JavaMail.zimbra@redhat.com>

On Fri, Oct 02, 2015 at 09:56:17AM -0400, Marc-André Lureau wrote:
> Hi
> 
> ----- Original Message -----
> > On Thu, Oct 01, 2015 at 07:23:47PM +0200, marcandre.lureau@redhat.com wrote:
> > > diff --git a/util/Makefile.objs b/util/Makefile.objs
> > > index 372e037..9e05861 100644
> > > --- a/util/Makefile.objs
> > > +++ b/util/Makefile.objs
> > > @@ -1,13 +1,18 @@
> > >  util-obj-y = osdep.o cutils.o unicode.o qemu-timer-common.o
> > >  util-obj-$(CONFIG_WIN32) += oslib-win32.o qemu-thread-win32.o
> > >  event_notifier-win32.o
> > > -util-obj-$(CONFIG_POSIX) += oslib-posix.o qemu-thread-posix.o
> > > event_notifier-posix.o qemu-openpty.o mmap-alloc.o
> > > +util-obj-$(CONFIG_POSIX) += oslib-posix.o
> > > +util-obj-$(CONFIG_POSIX) += qemu-thread-posix.o
> > > +util-obj-$(CONFIG_POSIX) += event_notifier-posix.o
> > > +util-obj-$(CONFIG_POSIX) += qemu-openpty.o
> > > +util-obj-$(CONFIG_POSIX) += compatfd.o
> > > +util-obj-$(CONFIG_POSIX) += mmap-alloc.o
> > > +util-obj-$(CONFIG_POSIX) += memfd.o
> > >  util-obj-y += envlist.o path.o module.o
> > >  util-obj-$(call lnot,$(CONFIG_INT128)) += host-utils.o
> > >  util-obj-y += bitmap.o bitops.o hbitmap.o
> > >  util-obj-y += fifo8.o
> > >  util-obj-y += acl.o
> > >  util-obj-y += error.o qemu-error.o
> > > -util-obj-$(CONFIG_POSIX) += compatfd.o
> > >  util-obj-y += id.o
> > >  util-obj-y += iov.o qemu-config.o qemu-sockets.o uri.o notify.o
> > >  util-obj-y += qemu-option.o qemu-progress.o
> > 
> > Will be easier to apply if this refactoring is a separate patch.
> > 
> > 
> Sure, would you mind to do it if you pick the series, or does this deserve another update?

Pls send an update.  I just posted a pull request, so we have some time
to get it right until I send the next one.

-- 
MST

  reply	other threads:[~2015-10-02 14:01 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-01 17:23 [Qemu-devel] [PATCH v7 00/24] vhost-user: add migration support marcandre.lureau
2015-10-01 17:23 ` [Qemu-devel] [PATCH v7 01/24] configure: probe for memfd marcandre.lureau
2015-10-01 17:23 ` [Qemu-devel] [PATCH v7 02/24] linux-headers: add unistd.h marcandre.lureau
2015-10-01 17:23 ` [Qemu-devel] [PATCH v7 03/24] util: add linux-only memfd fallback marcandre.lureau
2015-10-02 13:39   ` Michael S. Tsirkin
2015-10-02 13:56     ` Marc-André Lureau
2015-10-02 14:01       ` Michael S. Tsirkin [this message]
2015-10-02 15:57     ` Paolo Bonzini
2015-10-02 18:26       ` Marc-André Lureau
2015-10-02 18:35         ` Paolo Bonzini
2015-10-04  8:42       ` Michael S. Tsirkin
2015-10-01 17:23 ` [Qemu-devel] [PATCH v7 04/24] util: add memfd helpers marcandre.lureau
2015-10-01 17:23 ` [Qemu-devel] [PATCH v7 05/24] util: add fallback for qemu_memfd_alloc() marcandre.lureau
2015-10-01 17:23 ` [Qemu-devel] [PATCH v7 06/24] vhost: document log resizing marcandre.lureau
2015-10-01 17:23 ` [Qemu-devel] [PATCH v7 07/24] vhost: add vhost_set_log_base op marcandre.lureau
2015-10-01 17:23 ` [Qemu-devel] [PATCH v7 08/24] vhost-user: add vhost_user_requires_shm_log() marcandre.lureau
2015-10-01 17:23 ` [Qemu-devel] [PATCH v7 09/24] vhost: alloc shareable log marcandre.lureau
2015-10-01 17:23 ` [Qemu-devel] [PATCH v7 10/24] vhost-user: send log shm fd along with log_base marcandre.lureau
2015-10-01 17:23 ` [Qemu-devel] [PATCH v7 11/24] vhost-user: add a migration blocker marcandre.lureau
2015-10-01 17:23 ` [Qemu-devel] [PATCH v7 12/24] vhost: use a function for each call marcandre.lureau
2015-10-07 15:45   ` Thibaut Collet
2015-10-07 15:58     ` Marc-André Lureau
2015-10-07 16:04       ` Thibaut Collet
2015-10-07 16:08         ` Marc-André Lureau
2015-10-01 17:23 ` [Qemu-devel] [PATCH v7 13/24] vhost-user: document migration log marcandre.lureau
2015-10-01 17:23 ` [Qemu-devel] [PATCH v7 14/24] net: add trace_vhost_user_event marcandre.lureau
2015-10-01 17:23 ` [Qemu-devel] [PATCH v7 15/24] vhost user: add support of live migration marcandre.lureau
2015-10-01 17:24 ` [Qemu-devel] [PATCH v7 16/24] vhost user: add rarp sending after live migration for legacy guest marcandre.lureau
2015-10-02 13:37   ` Michael S. Tsirkin
2015-10-02 13:55     ` Marc-André Lureau
2015-10-02 14:02       ` Michael S. Tsirkin
2015-10-02 14:38         ` Thibaut Collet
2015-10-01 17:24 ` [Qemu-devel] [PATCH v7 17/24] vhost-user: use an enum helper for features mask marcandre.lureau
2015-10-01 17:24 ` [Qemu-devel] [PATCH v7 18/24] vhost: add migration block if memfd failed marcandre.lureau
2015-10-01 17:24 ` [Qemu-devel] [PATCH v7 19/24] vhost-user-test: move wait_for_fds() out marcandre.lureau
2015-10-01 17:24 ` [Qemu-devel] [PATCH v7 20/24] vhost-user-test: remove useless static check marcandre.lureau
2015-10-01 17:24 ` [Qemu-devel] [PATCH v7 21/24] vhost-user-test: wrap server in TestServer struct marcandre.lureau
2015-10-01 17:24 ` [Qemu-devel] [PATCH v7 22/24] vhost-user-test: learn to tweak various qemu arguments marcandre.lureau
2015-10-01 17:24 ` [Qemu-devel] [PATCH v7 23/24] vhost-user-test: add live-migration test marcandre.lureau
2015-10-01 17:24 ` [Qemu-devel] [PATCH v7 24/24] vhost-user-test: check ownership during migration marcandre.lureau
2015-10-08 20:52 ` [Qemu-devel] [PATCH v7 00/24] vhost-user: add migration support Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151002170038-mutt-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=haifeng.lin@huawei.com \
    --cc=jasowang@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mlureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thibaut.collet@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).