From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60903) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zi0u5-0003Rq-Fs for qemu-devel@nongnu.org; Fri, 02 Oct 2015 10:01:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zi0u0-0000XR-GT for qemu-devel@nongnu.org; Fri, 02 Oct 2015 10:01:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41751) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zi0u0-0000XK-Bg for qemu-devel@nongnu.org; Fri, 02 Oct 2015 10:01:36 -0400 Date: Fri, 2 Oct 2015 17:01:30 +0300 From: "Michael S. Tsirkin" Message-ID: <20151002170038-mutt-send-email-mst@redhat.com> References: <1443720248-15482-1-git-send-email-marcandre.lureau@redhat.com> <1443720248-15482-4-git-send-email-marcandre.lureau@redhat.com> <20151002163907-mutt-send-email-mst@redhat.com> <1726570872.23125054.1443794177275.JavaMail.zimbra@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1726570872.23125054.1443794177275.JavaMail.zimbra@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v7 03/24] util: add linux-only memfd fallback List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau Cc: haifeng lin , thibaut collet , jasowang@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, marcandre lureau On Fri, Oct 02, 2015 at 09:56:17AM -0400, Marc-Andr=E9 Lureau wrote: > Hi >=20 > ----- Original Message ----- > > On Thu, Oct 01, 2015 at 07:23:47PM +0200, marcandre.lureau@redhat.com= wrote: > > > diff --git a/util/Makefile.objs b/util/Makefile.objs > > > index 372e037..9e05861 100644 > > > --- a/util/Makefile.objs > > > +++ b/util/Makefile.objs > > > @@ -1,13 +1,18 @@ > > > util-obj-y =3D osdep.o cutils.o unicode.o qemu-timer-common.o > > > util-obj-$(CONFIG_WIN32) +=3D oslib-win32.o qemu-thread-win32.o > > > event_notifier-win32.o > > > -util-obj-$(CONFIG_POSIX) +=3D oslib-posix.o qemu-thread-posix.o > > > event_notifier-posix.o qemu-openpty.o mmap-alloc.o > > > +util-obj-$(CONFIG_POSIX) +=3D oslib-posix.o > > > +util-obj-$(CONFIG_POSIX) +=3D qemu-thread-posix.o > > > +util-obj-$(CONFIG_POSIX) +=3D event_notifier-posix.o > > > +util-obj-$(CONFIG_POSIX) +=3D qemu-openpty.o > > > +util-obj-$(CONFIG_POSIX) +=3D compatfd.o > > > +util-obj-$(CONFIG_POSIX) +=3D mmap-alloc.o > > > +util-obj-$(CONFIG_POSIX) +=3D memfd.o > > > util-obj-y +=3D envlist.o path.o module.o > > > util-obj-$(call lnot,$(CONFIG_INT128)) +=3D host-utils.o > > > util-obj-y +=3D bitmap.o bitops.o hbitmap.o > > > util-obj-y +=3D fifo8.o > > > util-obj-y +=3D acl.o > > > util-obj-y +=3D error.o qemu-error.o > > > -util-obj-$(CONFIG_POSIX) +=3D compatfd.o > > > util-obj-y +=3D id.o > > > util-obj-y +=3D iov.o qemu-config.o qemu-sockets.o uri.o notify.o > > > util-obj-y +=3D qemu-option.o qemu-progress.o > >=20 > > Will be easier to apply if this refactoring is a separate patch. > >=20 > >=20 > Sure, would you mind to do it if you pick the series, or does this dese= rve another update? Pls send an update. I just posted a pull request, so we have some time to get it right until I send the next one. --=20 MST