From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37455) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjEo4-0000F9-Mw for qemu-devel@nongnu.org; Mon, 05 Oct 2015 19:04:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjEnz-0000R0-KE for qemu-devel@nongnu.org; Mon, 05 Oct 2015 19:04:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57372) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjEnz-0000Qu-Ev for qemu-devel@nongnu.org; Mon, 05 Oct 2015 19:04:27 -0400 Date: Tue, 6 Oct 2015 02:04:20 +0300 From: "Michael S. Tsirkin" Message-ID: <20151006020328-mutt-send-email-mst@redhat.com> References: <1443793405-15190-1-git-send-email-mst@redhat.com> <1443793405-15190-15-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 14/15] vhost-user-test: use tmpfs by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Yuanhan Liu , QEMU Developers , Paolo Bonzini On Mon, Oct 05, 2015 at 11:39:39PM +0100, Peter Maydell wrote: > On 2 October 2015 at 14:45, Michael S. Tsirkin wrote: > > Most people don't run make check by default, so they skip vhost-user > > unit tests. Solve this by using tmpfs instead, unless hugetlbfs is > > specified (using an environment variable). > > > > Signed-off-by: Michael S. Tsirkin > > Reviewed-by: Marc-Andr=E9 Lureau >=20 > Unfortunately I didn't notice before applying the pull, but this > is breaking 'make check' on AArch64 host for me: >=20 > TEST: tests/vhost-user-test... (pid=3D20205) > Warning: path not on HugeTLBFS: /tmp/vhost-test-gRpbwl > qemu-system-i386: -netdev vhost-user,id=3Dnet0,chardev=3Dchr0,vhostforc= e: > vhost-net support is not compiled in > qemu-system-i386: -netdev vhost-user,id=3Dnet0,chardev=3Dchr0,vhostforc= e: > failed to init vhost_net for queue 0 >=20 > Broken pipe > FAIL: tests/vhost-user-test >=20 > Probably reproducible on x86 if you configure with --disable-vhost-net, > though I haven't tried that. >=20 > Perhaps tests/vhost-user-test should be set up > in tests/Makefile using > check-qtest-i386-$(CONFIG_VHOST_USER) rather > than CONFIG_LINUX ? >=20 > I'd appreciate a quick fix, because this machine is in my set > of systems I test all pullreqs on now... >=20 > thanks > -- PMM ok first of all we need this: if I apply it, I see the same bug as you do. need to fix that too. Signed-off-by: Michael S. Tsirkin diff --git a/net/net.c b/net/net.c index 28a5597..1e6a082 100644 --- a/net/net.c +++ b/net/net.c @@ -902,9 +902,7 @@ static int (* const net_client_init_fun[NET_CLIENT_OP= TIONS_KIND_MAX])( [NET_CLIENT_OPTIONS_KIND_BRIDGE] =3D net_init_bridge, #endif [NET_CLIENT_OPTIONS_KIND_HUBPORT] =3D net_init_hubport, -#ifdef CONFIG_VHOST_NET_USED [NET_CLIENT_OPTIONS_KIND_VHOST_USER] =3D net_init_vhost_user, -#endif #ifdef CONFIG_L2TPV3 [NET_CLIENT_OPTIONS_KIND_L2TPV3] =3D net_init_l2tpv3, #endif