From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39722) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjF0H-0002pI-BX for qemu-devel@nongnu.org; Mon, 05 Oct 2015 19:17:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjF0D-0005jI-7N for qemu-devel@nongnu.org; Mon, 05 Oct 2015 19:17:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55599) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjF0D-0005jD-2G for qemu-devel@nongnu.org; Mon, 05 Oct 2015 19:17:05 -0400 Date: Tue, 6 Oct 2015 02:17:00 +0300 From: "Michael S. Tsirkin" Message-ID: <20151006021426-mutt-send-email-mst@redhat.com> References: <1443793405-15190-1-git-send-email-mst@redhat.com> <1443793405-15190-15-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 14/15] vhost-user-test: use tmpfs by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Yuanhan Liu , QEMU Developers , Paolo Bonzini On Mon, Oct 05, 2015 at 11:39:39PM +0100, Peter Maydell wrote: > On 2 October 2015 at 14:45, Michael S. Tsirkin wrote: > > Most people don't run make check by default, so they skip vhost-user > > unit tests. Solve this by using tmpfs instead, unless hugetlbfs is > > specified (using an environment variable). > > > > Signed-off-by: Michael S. Tsirkin > > Reviewed-by: Marc-Andr=E9 Lureau >=20 > Unfortunately I didn't notice before applying the pull, but this > is breaking 'make check' on AArch64 host for me: >=20 > TEST: tests/vhost-user-test... (pid=3D20205) > Warning: path not on HugeTLBFS: /tmp/vhost-test-gRpbwl > qemu-system-i386: -netdev vhost-user,id=3Dnet0,chardev=3Dchr0,vhostforc= e: > vhost-net support is not compiled in > qemu-system-i386: -netdev vhost-user,id=3Dnet0,chardev=3Dchr0,vhostforc= e: > failed to init vhost_net for queue 0 >=20 > Broken pipe > FAIL: tests/vhost-user-test >=20 > Probably reproducible on x86 if you configure with --disable-vhost-net, > though I haven't tried that. >=20 > Perhaps tests/vhost-user-test should be set up > in tests/Makefile using > check-qtest-i386-$(CONFIG_VHOST_USER) rather > than CONFIG_LINUX ? >=20 > I'd appreciate a quick fix, because this machine is in my set > of systems I test all pullreqs on now... >=20 > thanks > -- PMM I think you are right, but just to be on the safe side, let's test both for now. If this helps you, pls feel free to apply. I will look at cleaning this up later. --> tests: vhost-user: disable unless CONFIG_VHOST_NET vhost-user depends on vhost-net. We should probably fix that. For now, let's disable the test otherwise. Signed-off-by: Michael S. Tsirkin --- diff --git a/tests/Makefile b/tests/Makefile index 4063639..e6474ba 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -188,7 +188,9 @@ gcov-files-i386-y +=3D hw/usb/hcd-xhci.c check-qtest-i386-y +=3D tests/pc-cpu-test$(EXESUF) check-qtest-i386-y +=3D tests/q35-test$(EXESUF) gcov-files-i386-y +=3D hw/pci-host/q35.c +ifeq ($(CONFIG_VHOST_NET),y) check-qtest-i386-$(CONFIG_LINUX) +=3D tests/vhost-user-test$(EXESUF) +endif check-qtest-x86_64-y =3D $(check-qtest-i386-y) gcov-files-i386-y +=3D i386-softmmu/hw/timer/mc146818rtc.c gcov-files-x86_64-y =3D $(subst i386-softmmu/,x86_64-softmmu/,$(gcov-fil= es-i386-y))