From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjIwe-0001eZ-HU for qemu-devel@nongnu.org; Mon, 05 Oct 2015 23:29:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjIwb-0007Ef-BM for qemu-devel@nongnu.org; Mon, 05 Oct 2015 23:29:40 -0400 Received: from ozlabs.org ([103.22.144.67]:54643) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjIwa-0007D0-Vx for qemu-devel@nongnu.org; Mon, 05 Oct 2015 23:29:37 -0400 Date: Tue, 6 Oct 2015 14:29:53 +1100 From: David Gibson Message-ID: <20151006032953.GE3861@voom.fritz.box> References: <1444034124-28747-1-git-send-email-bharata@linux.vnet.ibm.com> <1444034124-28747-2-git-send-email-bharata@linux.vnet.ibm.com> <20151005110507.213a8314@nial.brq.redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BZaMRJmqxGScZ8Mx" Content-Disposition: inline In-Reply-To: <20151005110507.213a8314@nial.brq.redhat.com> Subject: Re: [Qemu-devel] [RFC v0 1/2] spapr: Accommadate alignment gaps in hotplug memory region List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, Bharata B Rao --BZaMRJmqxGScZ8Mx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 05, 2015 at 11:05:07AM +0200, Igor Mammedov wrote: > On Mon, 5 Oct 2015 14:05:23 +0530 > Bharata B Rao wrote: >=20 > > Size hotplug memory region assuming a 256MB max alignment every slot. > >=20 > > Signed-off-by: Bharata B Rao > > --- > > hw/ppc/spapr.c | 3 +++ > > 1 file changed, 3 insertions(+) > >=20 > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > > index fc5e7d6..2ec509b 100644 > > --- a/hw/ppc/spapr.c > > +++ b/hw/ppc/spapr.c > > @@ -1792,6 +1792,9 @@ static void ppc_spapr_init(MachineState *machine) > > =20 > > spapr->hotplug_memory.base =3D ROUND_UP(machine->ram_size, > > SPAPR_HOTPLUG_MEM_ALIGN); > > + > > + /* size hotplug region assuming 256M max alignment per slot */ > > + hotplug_mem_size +=3D SPAPR_MEMORY_BLOCK_SIZE * machine->ram_s= lots; > Does target support hugepages backend? If it does then adjustment probably > should be max supported hugepage alignment. Hrm, so the maximum possible page size on Power is 16G (though we don't yet support that on "powernv" which is what the host system will generally be). Not sure if the possibility of 16G "colossal pages" in future is enough reason to put such a huge gap. There aren't any other page sizes between 16MB and 16GB. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --BZaMRJmqxGScZ8Mx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIbBAEBAgAGBQJWE0AxAAoJEGw4ysog2bOSZ5YP+K+u36t9/u9icQ9hj9d1Nbp7 p+2JwyRL/tbeLzRnvwdAo9Sntv6cb0ZLddyGibruOBvvBiW4E3SCcQBTK8TRrMwD vM9+Eqo6WCi+9ybXMtSsMkYIwWDHeMW5ohq8ta4k5mYfFNA4qkKtzgzsRJM606kR seUkuag31fg2Aoqo5MlGhqZw2rWzgCMVspTYg+FwW/5n6iqqppmspirEVWkEwHVE 6L2ewa1WB4u3P72CJkQ8E5HEyr8MTcgr7VWpALeaZF+kNBUaS63f1AvzfPIp6PuH pdaZyZBdkABslNYoSLZ7N7USIa7iFwEth2740EVoYr09JQ7rkIo2N42pM05GSNyo Sx9GfG4vOd0AAZhPruGCYiV43pPT3NjUYgtAjRPhHpH+qoglOJ8b5t1tybteE6lb TybqQJBRH1O/oVJGt6Wr4NpZVACNAKGD5LZMaQ6CjxhMuX6j4TsE3fxpfM31rYQy a+X97CL0mcqKckCg+rXWt+DTAMJ1LcH5tMBBmkVg4Z8MbYaxh4cr4IZ6+/sqfVJE 76DGoSSDHB3VZ0XAgGxTWBf4Xeej31mtoM3lCUr/6HGfcutq9a7H3ePkzCjGejrx ap60M8YmO7P1yw/ecL9tJccDkWDCXdfii89+6JbACYF3KAZx1AsxjMOcQY3zwVq3 RKqaNvkvtUcboRzc67k= =x4GO -----END PGP SIGNATURE----- --BZaMRJmqxGScZ8Mx--