From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41510) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjNnl-0007Kh-Tt for qemu-devel@nongnu.org; Tue, 06 Oct 2015 04:40:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjNni-0001ss-JO for qemu-devel@nongnu.org; Tue, 06 Oct 2015 04:40:49 -0400 Received: from mail-wi0-x22b.google.com ([2a00:1450:400c:c05::22b]:33288) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjNni-0001sT-Dw for qemu-devel@nongnu.org; Tue, 06 Oct 2015 04:40:46 -0400 Received: by wiclk2 with SMTP id lk2so155837725wic.0 for ; Tue, 06 Oct 2015 01:40:46 -0700 (PDT) Date: Tue, 6 Oct 2015 08:59:18 +0100 From: Stefan Hajnoczi Message-ID: <20151006075918.GB18212@stefanha-thinkpad> References: <1444071998-3596-1-git-send-email-nutanshinde1992@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444071998-3596-1-git-send-email-nutanshinde1992@gmail.com> Subject: Re: [Qemu-devel] [PATCH] Remove macros IO_READ_PROTO and IO_WRITE_PROTO List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: nutanshinde1992 Cc: qemu-devel@nongnu.org On Tue, Oct 06, 2015 at 12:36:38AM +0530, nutanshinde1992 wrote: > --- > hw/audio/adlib.c | 9 ++------- > hw/audio/es1370.c | 17 ++++++----------- > hw/audio/gus.c | 9 ++------- > hw/audio/sb16.c | 15 +++++---------- > 4 files changed, 15 insertions(+), 35 deletions(-) Apart from Peter's comments about the coding style and missing Signed-off-by: Reviewed-by: Stefan Hajnoczi