From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41508)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ZjNnl-0007Ke-Tk
	for qemu-devel@nongnu.org; Tue, 06 Oct 2015 04:40:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ZjNnj-0001th-Sc
	for qemu-devel@nongnu.org; Tue, 06 Oct 2015 04:40:49 -0400
Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:33291)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ZjNnj-0001tP-NP
	for qemu-devel@nongnu.org; Tue, 06 Oct 2015 04:40:47 -0400
Received: by wiclk2 with SMTP id lk2so155838582wic.0
	for <qemu-devel@nongnu.org>; Tue, 06 Oct 2015 01:40:47 -0700 (PDT)
Date: Tue, 6 Oct 2015 09:04:43 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20151006080443.GC18212@stefanha-thinkpad>
References: <1444089115-28710-1-git-send-email-kevin@koconnor.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1444089115-28710-1-git-send-email-kevin@koconnor.net>
Subject: Re: [Qemu-devel] [PATCHv2] fw_cfg: Define a static signature to be
 returned on DMA port reads
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: Marc =?iso-8859-1?Q?Mar=ED?= <markmb@redhat.com>, Laszlo Ersek <lersek@redhat.com>, qemu-devel@nongnu.org

On Mon, Oct 05, 2015 at 07:51:55PM -0400, Kevin O'Connor wrote:
> +static uint64_t fw_cfg_dma_mem_read(void *opaque, hwaddr addr,
> +                                    unsigned size)
> +{
> +    // Return a signature value (and handle various read sizes)
> +    return extract64(FW_CFG_DMA_SIGNATURE, (8 - addr - size) * 8, size*8);

Perhaps the maintainer can s/size*8/size * 8/ when applying this patch.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>