From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41557) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjNno-0007MD-5E for qemu-devel@nongnu.org; Tue, 06 Oct 2015 04:40:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjNnn-0001ym-Du for qemu-devel@nongnu.org; Tue, 06 Oct 2015 04:40:52 -0400 Received: from mail-wi0-x233.google.com ([2a00:1450:400c:c05::233]:33301) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjNnn-0001y6-7K for qemu-devel@nongnu.org; Tue, 06 Oct 2015 04:40:51 -0400 Received: by wiclk2 with SMTP id lk2so155840901wic.0 for ; Tue, 06 Oct 2015 01:40:50 -0700 (PDT) Date: Tue, 6 Oct 2015 09:09:14 +0100 From: Stefan Hajnoczi Message-ID: <20151006080914.GB19089@stefanha-thinkpad> References: <20151005090710.20420.26941.stgit@bahia.huguette.org> <20151005090722.20420.71571.stgit@bahia.huguette.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151005090722.20420.71571.stgit@bahia.huguette.org> Subject: Re: [Qemu-devel] [PATCH 2/3] virtio-9p: add unrealize handler List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz Cc: "Michael S. Tsirkin" , aneesh.kumar@linux.vnet.ibm.com, qemu-devel@nongnu.org On Mon, Oct 05, 2015 at 11:07:23AM +0200, Greg Kurz wrote: > If the user tries to hot unplug a virtio-9p device, it seems to succeed but > in fact: > - virtio-9p coroutines thread pool and async queue are leaked > - QEMU crashes in virtio_vmstate_change() if the user tries to live migrate > > This patch brings hot unplug support to virtio-9p-device. It fixes both > above issues. > > Signed-off-by: Greg Kurz > --- > hw/9pfs/virtio-9p-device.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) What happens to in-flight I/O requests? We cannot assume that the guest driver quiesces the device.