From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51160) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjTsC-0000sC-0U for qemu-devel@nongnu.org; Tue, 06 Oct 2015 11:09:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjTs6-0001XQ-7j for qemu-devel@nongnu.org; Tue, 06 Oct 2015 11:09:47 -0400 Date: Tue, 6 Oct 2015 17:09:34 +0200 From: Kevin Wolf Message-ID: <20151006150934.GB24770@noname.str.redhat.com> References: <1442500386-3668-1-git-send-email-berto@igalia.com> <55FC33BC.5080803@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9zSXsLTf0vkW971A" Content-Disposition: inline In-Reply-To: <55FC33BC.5080803@redhat.com> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] throttle: test that snapshots move the throttling configuration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Alberto Garcia , qemu-devel@nongnu.org, qemu-block@nongnu.org --9zSXsLTf0vkW971A Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 18.09.2015 um 17:54 hat Max Reitz geschrieben: > On 17.09.2015 16:33, Alberto Garcia wrote: > > If a snapshot is performed on a device that has I/O limits they should > > be moved to the target image (the new active layer). > >=20 > > Signed-off-by: Alberto Garcia > > --- > > tests/qemu-iotests/096 | 69 ++++++++++++++++++++++++++++++++++++++= ++++++++ > > tests/qemu-iotests/096.out | 5 ++++ > > tests/qemu-iotests/group | 1 + > > 3 files changed, 75 insertions(+) > > create mode 100644 tests/qemu-iotests/096 > > create mode 100644 tests/qemu-iotests/096.out >=20 > Looks good, I'd just like to throw in that 096 is in use by my > looks-dead-but-actually-is-not and > only-waiting-for-the-blockbackend-and-media-series-to-get-merged series > "block: Rework bdrv_close_all()": > http://lists.nongnu.org/archive/html/qemu-block/2015-03/msg00048.html >=20 > But then again, once the prerequisites are met, I'll have to send a new > version of that series anyway... It's generally a good idea to check the mailing list for test numbers taken by posted, but not yet merged patches. If there are any gaps in groups, chances are high that some patch is using it, so don't fill gaps without checking that first. > So, since 096 is not a magic number I'm extremely keen on keeping in my > greedy claws: >=20 > Reviewed-by: Max Reitz Thanks, applied to the block branch. Kevin --9zSXsLTf0vkW971A Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJWE+QuAAoJEH8JsnLIjy/WmnoP/25m7qmej6YI3PNx24yhQ6um M1v1J0IlSw3++iEEyYClG2uIwIUwjGcdS2oxx/LG0+5BLdjfWD0a+i+YBIbqsc41 xhvgEdM/NBmhdMRccRlxW+PyxtszbKBrs22r30Xk8WxSkn92WBQ2W2+8RiiFZW7R mwLhruy5EOF9gpezVFa6BETeNCsNHy79pNhjIN7k1/7ajQCKiHiqGnuc+xFqQDwj vCnDoPY6N8Sg+j1X6/gew96xQj2RMsLy9LYxJm14CuxQ6kuWPyxQqJ0VGADdQfEn eKMnWtKnhIxtQIZSCsB6fSCvEzge86NDbDGiJovmcGgVBx6dGr7CHraB2voKKdq1 UIeCPgSIn6nmstpM9AlqSDQeJUaAHyXQ6RZp5T2EjSt7+yPiyRZpHsiQtWrj9a8Y vZsg2z62KjB5bGgjAqFo9S3S/T3LCgiGKTRcgqgkspzgI0NNXp/dOFDKgRzaF3FS vtJvRQWavhLKY3E4t7DrI46evXxNdXRIvzPt/b61S54d0XaJJ1MonwRDBqwGe2FN bGIq9tCsQAoCvEA6bgxYh+RyBZDbwgrM6vBL/BUtAbx6wGc4cWUhPQ3v5fowQxo9 jS65aVawARNorTWt/uq+gVmAonsWyKIDRZfbJgICVSDbBdOMBYHoqKsdgy3u5YOR dr+PNvoFAqpFLM1ZhDnp =HBe9 -----END PGP SIGNATURE----- --9zSXsLTf0vkW971A--