From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48312) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjlBG-0000px-9L for qemu-devel@nongnu.org; Wed, 07 Oct 2015 05:38:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjlBC-0008K2-32 for qemu-devel@nongnu.org; Wed, 07 Oct 2015 05:38:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48068) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjlBB-0008Iz-Sy for qemu-devel@nongnu.org; Wed, 07 Oct 2015 05:38:34 -0400 Date: Wed, 7 Oct 2015 11:38:30 +0200 From: Kevin Wolf Message-ID: <20151007093830.GC4337@noname.redhat.com> References: <1443443772-7630-1-git-send-email-prasanna.kalever@redhat.com> <20151007090958.GK712645@andariel.pipo.sk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="45Z9DzgjV8m4Oswq" Content-Disposition: inline In-Reply-To: <20151007090958.GK712645@andariel.pipo.sk> Subject: Re: [Qemu-devel] [PATCH v5 1/1] block/gluster: add support for multiple gluster backup volfile servers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Krempa Cc: Prasanna Kumar Kalever , stefanha@gmail.com, qemu-devel@nongnu.org, deepakcs@redhat.com, bharata@linux.vnet.ibm.com, rtalur@redhat.com --45Z9DzgjV8m4Oswq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 07.10.2015 um 11:09 hat Peter Krempa geschrieben: > On Mon, Sep 28, 2015 at 18:06:12 +0530, Prasanna Kumar Kalever wrote: > > driver =3D> 'gluster' (protocol name) > > volname =3D> name of gluster volume where our VM image resides > > image-path =3D> is the absolute path of image in gluster volume > >=20 > > {tuple} =3D> {"server":"1.2.3.4"[,"port":"24007","transport":"t= cp"]} > >=20 > > server =3D> server address (hostname/ipv4/ipv6 addresses) > > port =3D> port number on which glusterd is listening. (defau= lt 24007) > > tranport =3D> transport type used to connect to gluster manageme= nt daemon, > > it can be tcp|rdma (default 'tcp') > >=20 > > Examples: > > 1. > > -drive driver=3Dqcow2,file.driver=3Dgluster, > > file.volname=3Dtestvol,file.image-path=3D/path/a.qcow2, > > file.volfile-servers.0.server=3D1.2.3.4, > > file.volfile-servers.0.port=3D24007, > > file.volfile-servers.0.transport=3Dtcp, > > file.volfile-servers.1.server=3D5.6.7.8, > > file.volfile-servers.1.port=3D24008, > > file.volfile-servers.1.transport=3Drdma > > 2. > > 'json:{"driver":"qcow2","file":{"driver":"gluster","volname":"testvol", > > "image-path":"/path/a.qcow2","volfile-servers": > > [{"server":"1.2.3.4","port":"24007","transport":"tcp"}, > > {"server":"4.5.6.7","port":"24008","transport":"rdma"}] } }' >=20 > -drive driver=3Dqcow2,file.driver=3Dgluster, > file.volume=3Dtestvol, > file.path=3D/path/a.qcow2, > file.server.0.host=3D1.2.3.4, > file.server.0.port=3D24007, > file.server.0.transport=3Dtcp, > file.server.1.host=3D5.6.7.8, > file.server.1.port=3D24008, > file.server.1.transport=3Drdma >=20 > I'm suggesting the above naming scheme. > So: > 'path' instead of 'image-path' > 'volume' instead of 'volname' > 'server' instead of 'volfile-servers' > 'host' instead of 'server' I agree, let's keep the names short so they are easy to read, type and remember. I especially agree with changing 'server' into 'host' because that makes it consistent with InetSocketAddress. Kevin --45Z9DzgjV8m4Oswq Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJWFOgWAAoJEH8JsnLIjy/WnR4QAIkufPG/WKdxIY1kpesFapLT 4mP96Yv/+Vu/OZa4lbcm2EI+9gghgyoH0eTrCxVD/oyqEj+Cr2eMLdteOv3y9eyy m/HKndHb8UcFsMash0Hq2yyaX+KKX+930w9L8oCTfJHwyNvayBuEUL5B6mrHJ5Yl j58ZSVbUKMlgGH5gEvekFWAd2jDJW9vPXfLvB1Ps4v8+N1/mCN8zInLCU2U2pbcj B14L6EvZIAoyu+SBNSMHTBoYvF4qmEopvmQT5UM26x0nSliXXxYhkKgmGGMN1v5E +pF9N+vPMB6DwtYawNKKtUBkgjYSwOS+T3V5FruQKU9xI7RW3J8H1U6e8glUqLR2 VZkeSvICtMK8TuRylcn02Jrh5oAJ+URCctWx8JI3CgDPO8Bz72q1h+clDjiNDaH0 Vu5eG8pQ/TJ2SEJfdaIPorifBBmvcZ4x30B/qFqWbyHu7IyzjKt7Rk1W8qqNQPzl xWMKKn62gmWUina80nGKFgHTByRrqdA1W28ZzK9ry7MnvkK6s7eSwrIx4L+Q8cR7 T/IbrT2vqtEPsHHyaBPoWKsL2FA+aNl0cBYjPb9HNGkS9cqw67m107PuSD16cqxN ZWhYrgoAJJSKiMxwq6k43SUE09pt+MnOmDl9AQtJyY2c6r2oC/cwLpuLFo3Biwju Os0DBN6xN4xMzJN3AMtY =V99q -----END PGP SIGNATURE----- --45Z9DzgjV8m4Oswq--