From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] block: switch from g_slice allocator to malloc
Date: Thu, 8 Oct 2015 11:41:17 +0200 [thread overview]
Message-ID: <20151008094117.GB5379@noname.redhat.com> (raw)
In-Reply-To: <20151008085444.GA29433@stefanha-thinkpad.redhat.com>
Am 08.10.2015 um 10:54 hat Stefan Hajnoczi geschrieben:
> On Thu, Oct 01, 2015 at 01:04:39PM +0200, Paolo Bonzini wrote:
> > Simplify memory allocation by sticking with a single API. GSlice
> > is not that fast anyway (tcmalloc/jemalloc are better).
> >
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
> > block/io.c | 4 ++--
> > block/mirror.c | 4 ++--
> > block/raw-posix.c | 8 ++++----
> > block/raw-win32.c | 4 ++--
> > hw/block/virtio-blk.c | 4 ++--
> > 5 files changed, 12 insertions(+), 12 deletions(-)
>
> Thanks, applied to my block tree:
> https://github.com/stefanha/qemu/commits/block
Has someone benchmarked this before applying? Just claiming "wasn't fast
anyway" doesn't generally seem sufficient for changes to the I/O path.
Kevin
next prev parent reply other threads:[~2015-10-08 9:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 11:04 [Qemu-devel] [PATCH] block: switch from g_slice allocator to malloc Paolo Bonzini
2015-10-08 8:54 ` Stefan Hajnoczi
2015-10-08 9:41 ` Kevin Wolf [this message]
2015-10-09 7:49 ` Paolo Bonzini
2015-10-09 8:15 ` Kevin Wolf
2015-10-09 10:29 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151008094117.GB5379@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).