From: Stefan Hajnoczi <stefanha@gmail.com>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>
Cc: Bazhaniuk Oleksandr <oleksandr.bazhaniuk@intel.com>,
Peter Maydell <peter.maydell@linaro.org>,
Igor Mitsyanko <i.mitsyanko@gmail.com>,
Markus Armbruster <armbru@redhat.com>,
Walter James L <james.l.walter@intel.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
Alistair Francis <alistair.francis@xilinx.com>,
Sai Pavan Boddu <saipava@xilinx.com>,
Kevin OConnor <kevin@koconnor.net>,
wehuang@redhat.com, John Snow <jsnow@redhat.com>,
secure@intel.com
Subject: Re: [Qemu-devel] [PATCH v1 1/1] sdhci.c: Limit the maximum block size
Date: Thu, 8 Oct 2015 10:49:27 +0100 [thread overview]
Message-ID: <20151008094927.GB14090@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <CAPokK=p9-7Qw++Ohon0jwn=Rrpvt=cqTmBL+2Gu6Gn5Y+b1Obg@mail.gmail.com>
On Tue, Oct 06, 2015 at 11:34:46AM -0700, Peter Crosthwaite wrote:
> On Tue, Oct 6, 2015 at 10:40 AM, Alistair Francis
> <alistair.francis@xilinx.com> wrote:
> > It is possible for the guest to set an invalid block
> > size which is larger then the fifo_buffer[] array. This
> > could cause a buffer overflow.
> >
> > To avoid this limit the maximum size of the blksize variable.
> >
> > Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> > Suggested-by: Igor Mitsyanko <i.mitsyanko@gmail.com>
> > Reported-by: Intel Security ATR <secure@intel.com>
> > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>
> Reviewed-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
>
> With Pavan's patches and now this, the SD patches are starting to pile
> up on list. What queue do they target? target-arm (as lead/major user)
> or something block-related?
I can pick them up for now in my block pull requests. Note that I'm not
an SD expert so I can't review/maintain the code.
Stefan
next prev parent reply other threads:[~2015-10-08 9:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 17:40 [Qemu-devel] [PATCH v1 1/1] sdhci.c: Limit the maximum block size Alistair Francis
2015-10-06 18:34 ` Peter Crosthwaite
2015-10-08 9:49 ` Stefan Hajnoczi [this message]
2015-10-08 15:46 ` Alistair Francis
2015-10-08 9:50 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151008094927.GB14090@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=alistair.francis@xilinx.com \
--cc=armbru@redhat.com \
--cc=crosthwaitepeter@gmail.com \
--cc=i.mitsyanko@gmail.com \
--cc=james.l.walter@intel.com \
--cc=jsnow@redhat.com \
--cc=kevin@koconnor.net \
--cc=oleksandr.bazhaniuk@intel.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=saipava@xilinx.com \
--cc=secure@intel.com \
--cc=wehuang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).