From: Stefan Hajnoczi <stefanha@gmail.com>
To: Alistair Francis <alistair.francis@xilinx.com>
Cc: oleksandr.bazhaniuk@intel.com, peter.maydell@linaro.org,
i.mitsyanko@gmail.com, james.l.walter@intel.com,
qemu-devel@nongnu.org, armbru@redhat.com,
crosthwaitepeter@gmail.com, kevin@koconnor.net,
wehuang@redhat.com, jsnow@redhat.com, secure@intel.com
Subject: Re: [Qemu-devel] [PATCH v1 1/1] sdhci.c: Limit the maximum block size
Date: Thu, 8 Oct 2015 10:50:05 +0100 [thread overview]
Message-ID: <20151008095005.GC14090@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <abe4c51f513290bbb85d1ee271cb1a3d463d7561.1444067470.git.alistair.francis@xilinx.com>
On Tue, Oct 06, 2015 at 10:40:41AM -0700, Alistair Francis wrote:
> It is possible for the guest to set an invalid block
> size which is larger then the fifo_buffer[] array. This
> could cause a buffer overflow.
>
> To avoid this limit the maximum size of the blksize variable.
>
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> Suggested-by: Igor Mitsyanko <i.mitsyanko@gmail.com>
> Reported-by: Intel Security ATR <secure@intel.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>
> hw/sd/sdhci.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
prev parent reply other threads:[~2015-10-08 9:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 17:40 [Qemu-devel] [PATCH v1 1/1] sdhci.c: Limit the maximum block size Alistair Francis
2015-10-06 18:34 ` Peter Crosthwaite
2015-10-08 9:49 ` Stefan Hajnoczi
2015-10-08 15:46 ` Alistair Francis
2015-10-08 9:50 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151008095005.GC14090@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=alistair.francis@xilinx.com \
--cc=armbru@redhat.com \
--cc=crosthwaitepeter@gmail.com \
--cc=i.mitsyanko@gmail.com \
--cc=james.l.walter@intel.com \
--cc=jsnow@redhat.com \
--cc=kevin@koconnor.net \
--cc=oleksandr.bazhaniuk@intel.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=secure@intel.com \
--cc=wehuang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).