From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48300) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZkBJu-0002oS-VC for qemu-devel@nongnu.org; Thu, 08 Oct 2015 09:34:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZkBIq-0002Vs-TZ for qemu-devel@nongnu.org; Thu, 08 Oct 2015 09:33:18 -0400 Received: from e23smtp05.au.ibm.com ([202.81.31.147]:43017) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZkBIq-0002RH-Ag for qemu-devel@nongnu.org; Thu, 08 Oct 2015 09:32:12 -0400 Received: from /spool/local by e23smtp05.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 8 Oct 2015 23:32:08 +1000 Received: from d23relay06.au.ibm.com (d23relay06.au.ibm.com [9.185.63.219]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 82D072CE8054 for ; Fri, 9 Oct 2015 00:32:04 +1100 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay06.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t98DVpLd11010056 for ; Fri, 9 Oct 2015 00:32:00 +1100 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t98DVVbI015803 for ; Fri, 9 Oct 2015 00:31:31 +1100 Date: Thu, 8 Oct 2015 19:01:09 +0530 From: Bharata B Rao Message-ID: <20151008133109.GA29460@in.ibm.com> References: <1443538409-145558-1-git-send-email-imammedo@redhat.com> <1443538409-145558-2-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443538409-145558-2-git-send-email-imammedo@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 1/2] memhp: extend address auto assignment to support gaps Reply-To: bharata@linux.vnet.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: pbonzini@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, david@gibson.dropbear.id.au, ehabkost@redhat.com On Tue, Sep 29, 2015 at 04:53:28PM +0200, Igor Mammedov wrote: > setting gap to TRUE will make sparse DIMM > address auto allocation, leaving gaps between > a new DIMM address and preceeding existing DIMM. > > Signed-off-by: Igor Mammedov > --- > v2: > * make 'gap' boolean and just add 1 byte gap > when calculating new_addr for DIMM. > --- > hw/i386/pc.c | 3 ++- > hw/mem/pc-dimm.c | 15 +++++++++------ > hw/ppc/spapr.c | 2 +- > include/hw/mem/pc-dimm.h | 7 ++++--- > 4 files changed, 16 insertions(+), 11 deletions(-) > > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index 461c128..ef02736 100644 > --- a/hw/i386/pc.c > +++ b/hw/i386/pc.c > @@ -1644,7 +1644,8 @@ static void pc_dimm_plug(HotplugHandler *hotplug_dev, > goto out; > } > > - pc_dimm_memory_plug(dev, &pcms->hotplug_memory, mr, align, &local_err); > + pc_dimm_memory_plug(dev, &pcms->hotplug_memory, mr, align, false, > + &local_err); > if (local_err) { > goto out; > } > diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c > index bb04862..6cc6ac3 100644 > --- a/hw/mem/pc-dimm.c > +++ b/hw/mem/pc-dimm.c > @@ -32,7 +32,8 @@ typedef struct pc_dimms_capacity { > } pc_dimms_capacity; > > void pc_dimm_memory_plug(DeviceState *dev, MemoryHotplugState *hpms, > - MemoryRegion *mr, uint64_t align, Error **errp) > + MemoryRegion *mr, uint64_t align, bool gap, > + Error **errp) > { > int slot; > MachineState *machine = MACHINE(qdev_get_machine()); > @@ -48,7 +49,7 @@ void pc_dimm_memory_plug(DeviceState *dev, MemoryHotplugState *hpms, > > addr = pc_dimm_get_free_addr(hpms->base, > memory_region_size(&hpms->mr), > - !addr ? NULL : &addr, align, > + !addr ? NULL : &addr, align, gap, > memory_region_size(mr), &local_err); > if (local_err) { > goto out; > @@ -287,8 +288,8 @@ static int pc_dimm_built_list(Object *obj, void *opaque) > > uint64_t pc_dimm_get_free_addr(uint64_t address_space_start, > uint64_t address_space_size, > - uint64_t *hint, uint64_t align, uint64_t size, > - Error **errp) > + uint64_t *hint, uint64_t align, bool gap, > + uint64_t size, Error **errp) > { > GSList *list = NULL, *item; > uint64_t new_addr, ret = 0; > @@ -333,13 +334,15 @@ uint64_t pc_dimm_get_free_addr(uint64_t address_space_start, > goto out; > } > > - if (ranges_overlap(dimm->addr, dimm_size, new_addr, size)) { > + if (ranges_overlap(dimm->addr, dimm_size, new_addr, > + size + (gap ? 1 : 0))) { > if (hint) { > DeviceState *d = DEVICE(dimm); > error_setg(errp, "address range conflicts with '%s'", d->id); > goto out; > } > - new_addr = QEMU_ALIGN_UP(dimm->addr + dimm_size, align); > + new_addr = QEMU_ALIGN_UP(dimm->addr + dimm_size + (gap ? 1 : 0), > + align); This change of adding 1 byte gap will break PowerPC memory hotplug in its current form. Currently we divide hotpluggable memory region into chuncks of 256M and there is a DR connector object for each such chunk. The DR connector object maintains/controls the state transitions of that memory chunk as per PAPR specifications. Now after this 1 byte gap, we end up having a 64K alignment (default page size) for the DIMM address and end up having an address for which there is no DR connector object. I will have to revisit the parts of the code in PowerPC that creates DR connector objects and looks them up by address. Regards, Bharata.