From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41595) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZkDRl-0007fl-SX for qemu-devel@nongnu.org; Thu, 08 Oct 2015 11:49:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZkDQr-0005ud-1W for qemu-devel@nongnu.org; Thu, 08 Oct 2015 11:49:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49590) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZkDQq-0005uG-QF for qemu-devel@nongnu.org; Thu, 08 Oct 2015 11:48:36 -0400 Date: Thu, 8 Oct 2015 16:48:33 +0100 From: "Daniel P. Berrange" Message-ID: <20151008154833.GA16564@redhat.com> References: <1444313344-16196-1-git-send-email-berrange@redhat.com> <00d901d101dd$debc7d30$9c357790$@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <00d901d101dd$debc7d30$9c357790$@samsung.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 0/5] qom: more efficient object property handling Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Fedin Cc: qemu-devel@nongnu.org, 'Andreas =?utf-8?Q?F=C3=A4rber'?= On Thu, Oct 08, 2015 at 06:27:39PM +0300, Pavel Fedin wrote: > Hi! >=20 > Just got test report from my colleague, he forgot to specify --target-= list=3Daarch64-softmmu to configure and tried to build everything. Looks = like there are more property iterations done by hand in PowerPC code: > --- cut --- > In file included from /home/igor/qemu/include/qom/object.h:20:0, > from /home/igor/qemu/include/hw/ppc/spapr_drc.h:15, > from /home/igor/qemu/hw/ppc/spapr_drc.c:13: > /home/igor/qemu/hw/ppc/spapr_drc.c: In function =E2=80=98spapr_drc_popu= late_dt=E2=80=99: > /home/igor/qemu/include/qemu/queue.h:419:29: error: request for member=20 > =E2=80=98tqh_first=E2=80=99 in something not a structure or union > for ((var) =3D ((head)->tqh_first); = \ > ^ > /home/igor/qemu/hw/ppc/spapr_drc.c:683:5: note: in expansion of macro=20 > =E2=80=98QTAILQ_FOREACH=E2=80=99 > QTAILQ_FOREACH(prop, &root_container->properties, node) { > ^ > /home/igor/qemu/include/qemu/queue.h:421:31: error: =E2=80=98ObjectProp= erty=E2=80=99 has=20 > no member named =E2=80=98node=E2=80=99 > (var) =3D ((var)->field.tqe_next)) > ^ > /home/igor/qemu/hw/ppc/spapr_drc.c:683:5: note: in expansion of macro=20 > =E2=80=98QTAILQ_FOREACH=E2=80=99 > QTAILQ_FOREACH(prop, &root_container->properties, node) { > ^ > /home/igor/qemu/rules.mak:57: recipe for target 'hw/ppc/spapr_drc.o' fa= iled > make[1]: *** [hw/ppc/spapr_drc.o] Error 1 > Makefile:184: recipe for target 'subdir-ppc64-softmmu' failed > --- cut --- >=20 > Actually, he was building version with my standalone patch, but i have= checked your series, it also doesn't touch SPAPR code. Ah yes, I'll do an all-targets build and check this out. Regards, Daniel --=20 |: http://berrange.com -o- http://www.flickr.com/photos/dberrange= / :| |: http://libvirt.org -o- http://virt-manager.or= g :| |: http://autobuild.org -o- http://search.cpan.org/~danberr= / :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vn= c :|