From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36132)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZkSFU-00078J-Ly
	for qemu-devel@nongnu.org; Fri, 09 Oct 2015 03:37:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZkSFP-0007Cv-MM
	for qemu-devel@nongnu.org; Fri, 09 Oct 2015 03:37:52 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57335)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZkSFP-0007CT-Hd
	for qemu-devel@nongnu.org; Fri, 09 Oct 2015 03:37:47 -0400
Date: Fri, 9 Oct 2015 10:37:41 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20151009103708-mutt-send-email-mst@redhat.com>
References: <1444338957-15293-1-git-send-email-mst@redhat.com>
	<1444338957-15293-13-git-send-email-mst@redhat.com>
	<CABUUfwNtq988Qcvwyhaj=xD6OGp9uJqADR_i4oq0LFNe2iJE5g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CABUUfwNtq988Qcvwyhaj=xD6OGp9uJqADR_i4oq0LFNe2iJE5g@mail.gmail.com>
Subject: Re: [Qemu-devel] [PULL 12/25] vhost: use a function for each call
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thibaut Collet <thibaut.collet@6wind.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Jason Wang <jasowang@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, =?iso-8859-1?Q?Marc-Andr=E9?= Lureau <marcandre.lureau@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

On Fri, Oct 09, 2015 at 08:40:27AM +0200, Thibaut Collet wrote:
> Hi Michael,
> 
> this patch is not correct. If we apply QEMU enters in a dead lock if
> we have several queue pairs for virttio/vhost and vhost backend
> crashes during the initialisation sequence
> I have sent some comments yesterday to Marc to correct theses issues.
> The attached fixup solves the issues (already sent to Marc Andre on
> QEMU mailing list):
>  - The two first corrections solve the vhost backend crashes (the
> message id used for some messages are the kernel IOCTL and not the
> VHOST_USER id)
>  - the third patchs solves the QEMU dead lock in case of multiqueue
> (VHOST_USER_GET_QUEUE_NUM is a one time message. This message is sent
> through the new vhost_user_get_u64 function but except for the first
> queue a blocking read is sent whereas no write has been sent before
> that causes the lock)
> 
> If you (and Marc Andre) agree this correction could you update this
> patch with the fixup and resend the pull request ?
> 
> Thanks
> 
> Best regards.
> 
> Thibaut.

I dropped this and dependent patches from the tree for now.
Thanks!

-- 
MST