From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44829) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlYRo-0003bf-4k for qemu-devel@nongnu.org; Mon, 12 Oct 2015 04:27:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZlYRm-0006FO-Qi for qemu-devel@nongnu.org; Mon, 12 Oct 2015 04:27:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46873) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlYRm-0006F5-JX for qemu-devel@nongnu.org; Mon, 12 Oct 2015 04:27:06 -0400 Date: Mon, 12 Oct 2015 09:27:02 +0100 From: Stefan Hajnoczi Message-ID: <20151012082702.GA3412@stefanha-thinkpad.redhat.com> References: <1444382007-20416-1-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 0/5] Block patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Pierre Morel , QEMU Developers On Fri, Oct 09, 2015 at 12:17:54PM +0100, Peter Maydell wrote: > On 9 October 2015 at 10:13, Stefan Hajnoczi wrote= : > > The following changes since commit 1d27b91723c252d9a97151dc1959cfd89c= 5816cb: > > > > Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-201= 51007.0' into staging (2015-10-08 16:50:34 +0100) > > > > are available in the git repository at: > > > > git://github.com/stefanha/qemu.git tags/block-pull-request > > > > for you to fetch changes up to b22b254b8b61705517756060bd8e83edd30b99= 87: > > > > sdhci.c: Limit the maximum block size (2015-10-09 09:45:04 +0100) > > > > ---------------------------------------------------------------- > > > > ---------------------------------------------------------------- > > > > Alistair Francis (1): > > sdhci.c: Limit the maximum block size > > > > Kevin O'Connor (1): > > sdhci: Pass drive parameter to sdhci-pci via qdev property > > > > Paolo Bonzini (1): > > block: switch from g_slice allocator to malloc > > > > Pierre Morel (1): > > virtio dataplane: adapt dataplane for virtio Version 1 > > > > Stefan Hajnoczi (1): > > virtio-blk: use blk_io_plug/unplug for Linux AIO batching >=20 > Compiler warnings on OSX: >=20 > /Users/pm215/src/qemu-for-merges/hw/virtio/dataplane/vring.c:84:23: > warning: format specifies type 'unsigned long' but the argument has > type 'hwaddr' (aka 'unsigned long long') [-Wformat] > size, addr); > ^~~~ > /Users/pm215/src/qemu-for-merges/hw/virtio/dataplane/vring.c:84:29: > warning: format specifies type 'unsigned long' but the argument has > type 'hwaddr' (aka 'unsigned long long') [-Wformat] > size, addr); > ^~~~ > /Users/pm215/src/qemu-for-merges/hw/virtio/dataplane/vring.c:97:23: > warning: format specifies type 'unsigned long' but the argument has > type 'hwaddr' (aka 'unsigned long long') [-Wformat] > size, addr); > ^~~~ > /Users/pm215/src/qemu-for-merges/hw/virtio/dataplane/vring.c:97:29: > warning: format specifies type 'unsigned long' but the argument has > type 'hwaddr' (aka 'unsigned long long') [-Wformat] > size, addr); > ^~~~ > /Users/pm215/src/qemu-for-merges/hw/virtio/dataplane/vring.c:110:23: > warning: format specifies type 'unsigned long' but the argument has > type 'hwaddr' (aka 'unsigned long long') [-Wformat] > size, addr); > ^~~~ > /Users/pm215/src/qemu-for-merges/hw/virtio/dataplane/vring.c:110:29: > warning: format specifies type 'unsigned long' but the argument has > type 'hwaddr' (aka 'unsigned long long') [-Wformat] > size, addr); > ^~~~ > 6 warnings generated. >=20 >=20 > Same problem, w32 build: > /home/petmay01/linaro/qemu-for-merges/hw/virtio/dataplane/vring.c: In > function =E2=80=98vring_setup=E2=80=99: > /home/petmay01/linaro/qemu-for-merges/hw/virtio/dataplane/vring.c:84: > warning: format =E2=80=98%16lx=E2=80=99 expects > type =E2=80=98long unsigned int=E2=80=99, but argument 2 has type =E2=80= =98hwaddr=E2=80=99 > /home/petmay01/linaro/qemu-for-merges/hw/virtio/dataplane/vring.c:84: > warning: format =E2=80=98%16lx=E2=80=99 expects > type =E2=80=98long unsigned int=E2=80=99, but argument 3 has type =E2=80= =98hwaddr=E2=80=99 > /home/petmay01/linaro/qemu-for-merges/hw/virtio/dataplane/vring.c:97: > warning: format =E2=80=98%16lx=E2=80=99 expects > type =E2=80=98long unsigned int=E2=80=99, but argument 2 has type =E2=80= =98hwaddr=E2=80=99 > /home/petmay01/linaro/qemu-for-merges/hw/virtio/dataplane/vring.c:97: > warning: format =E2=80=98%16lx=E2=80=99 expects > type =E2=80=98long unsigned int=E2=80=99, but argument 3 has type =E2=80= =98hwaddr=E2=80=99 > /home/petmay01/linaro/qemu-for-merges/hw/virtio/dataplane/vring.c:110: > warning: format =E2=80=98%16lx=E2=80=99 expects > type =E2=80=98long unsigned int=E2=80=99, but argument 2 has type =E2=80= =98hwaddr=E2=80=99 > /home/petmay01/linaro/qemu-for-merges/hw/virtio/dataplane/vring.c:110: > warning: format =E2=80=98%16lx=E2=80=99 expects > type =E2=80=98long unsigned int=E2=80=99, but argument 3 has type =E2=80= =98hwaddr=E2=80=99 > make[1]: *** [hw/virtio/dataplane/vring.o] Error 1 Thanks for letting me know. Weird that I didn't see the warnings from my 32-bit Linux build. I am sending a v2 pull request with HWADDR_PRIx instead of the 16lx format specifier fixed in Pierre's patch. Stefan