From: Andrew Jones <drjones@redhat.com>
To: Pavel Fedin <p.fedin@samsung.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH 2/2] hw/arm/virt: don't use a15memmap directly
Date: Mon, 12 Oct 2015 14:07:35 +0200 [thread overview]
Message-ID: <20151012120735.GA4786@hawk.localdomain> (raw)
In-Reply-To: <016101d104bb$a8988ba0$f9c9a2e0$@samsung.com>
On Mon, Oct 12, 2015 at 10:00:19AM +0300, Pavel Fedin wrote:
> Hello!
>
> > Before this patch it would complain that the requested
> > number of cpus was greater than 123, but for gicv2 configs, it
> > should complain that the number is greater than 8.
>
> Actually, gicv2 code has own check, and it would complain about >8 CPU (see
> arm_gic_common_realize()).
It only gets a chance to do that check if the class init check doesn't
fail first, i.e. nr_cpus > 8 <= 123 will fail with a "> 8" message, but
nr_cpus > 123, as I wrote above, will fail with a "> 123" message.
drew
>
> Kind regards,
> Pavel Fedin
> Expert Engineer
> Samsung Electronics Research center Russia
>
>
>
prev parent reply other threads:[~2015-10-12 12:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 14:37 [Qemu-devel] [PATCH 0/2] hw/arm/virt: max-cpus init/check fixup Andrew Jones
2015-10-06 14:37 ` [Qemu-devel] [PATCH 1/2] [RFC] arm_gic_common.h: add gicv2 aliases for defines Andrew Jones
2015-10-09 16:41 ` Peter Maydell
2015-10-12 6:58 ` Pavel Fedin
2015-10-06 14:37 ` [Qemu-devel] [PATCH 2/2] hw/arm/virt: don't use a15memmap directly Andrew Jones
2015-10-09 16:45 ` Peter Maydell
2015-10-09 17:05 ` Andrew Jones
2015-10-12 7:00 ` Pavel Fedin
2015-10-12 12:07 ` Andrew Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151012120735.GA4786@hawk.localdomain \
--to=drjones@redhat.com \
--cc=afaerber@suse.de \
--cc=p.fedin@samsung.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).