From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60466) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlcHZ-0005pD-1F for qemu-devel@nongnu.org; Mon, 12 Oct 2015 08:32:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZlcHU-0002Xr-QJ for qemu-devel@nongnu.org; Mon, 12 Oct 2015 08:32:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20864) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlcHU-0002Xn-KW for qemu-devel@nongnu.org; Mon, 12 Oct 2015 08:32:44 -0400 Date: Mon, 12 Oct 2015 13:31:35 +0100 From: "Daniel P. Berrange" Message-ID: <20151012123135.GL21855@redhat.com> References: <1444647299-28642-1-git-send-email-marcandre.lureau@redhat.com> <20151012112608.GJ21855@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/3] Use glib 2.26 version macros Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: QEMU On Mon, Oct 12, 2015 at 02:24:36PM +0200, Marc-Andr=C3=A9 Lureau wrote: > Hi >=20 > On Mon, Oct 12, 2015 at 1:26 PM, Daniel P. Berrange wrote: > > On Mon, Oct 12, 2015 at 12:54:56PM +0200, marcandre.lureau@redhat.com= wrote: > >> From: Marc-Andr=C3=A9 Lureau > >> > >> Bump glib requirement to be able to use the GLIB_VERSION macros. > > > > We had a discussion about glib min version a few months back where it > > was decided 2.22 was the maximum we could use at the current time > > without us loosing support for certain platforms we care about. > > > > Simply being able to use the GLIB_VERSION macro does not seem like a > > compelling enough reason to re-vist this min version again right now, > > as I doubt we've changed our mind on what platforms we wish to target > > in the last couple of months. >=20 > Fair enough, I couldn't find the discussion where 2.22 was decided to > be the maximum requirement, but SLES11 seems to be the reason then. >=20 > What about just using the macro, but not bumping glib requirement? It would be desirable - I think someone explored using the GLIB_VERSION macros before, without bumping version. I can't remember what the problem was that made them abandon that though - maybe someone else recalls... Regards, Daniel --=20 |: http://berrange.com -o- http://www.flickr.com/photos/dberrange= / :| |: http://libvirt.org -o- http://virt-manager.or= g :| |: http://autobuild.org -o- http://search.cpan.org/~danberr= / :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vn= c :|