From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56473) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zlg3M-00024i-Oe for qemu-devel@nongnu.org; Mon, 12 Oct 2015 12:34:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zlg3J-0006vA-Ii for qemu-devel@nongnu.org; Mon, 12 Oct 2015 12:34:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58822) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zlg3J-0006v4-E3 for qemu-devel@nongnu.org; Mon, 12 Oct 2015 12:34:21 -0400 Date: Mon, 12 Oct 2015 17:34:17 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20151012163416.GA7808@work-vm> References: <1444647299-28642-1-git-send-email-marcandre.lureau@redhat.com> <20151012112608.GJ21855@redhat.com> <20151012123135.GL21855@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/3] Use glib 2.26 version macros List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , QEMU * Peter Maydell (peter.maydell@linaro.org) wrote: > On 12 October 2015 at 13:31, Daniel P. Berrange w= rote: > > On Mon, Oct 12, 2015 at 02:24:36PM +0200, Marc-Andr=E9 Lureau wrote: > >> What about just using the macro, but not bumping glib requirement? > > > > It would be desirable - I think someone explored using the GLIB_VERS= ION > > macros before, without bumping version. I can't remember what the pro= blem > > was that made them abandon that though - maybe someone else recalls..= . >=20 > I think that was David Gilbert, and I vaguely recall there being > bad interactions with our glib-compat.h header. My notes and memory are both somewhat fuzzy on it. I think that the GLIB_VERSION_MIN/MAX macros only went in in 2.32 but then once you have them they offer a range allowing you to state you need a minimum of 2.26; so if we bump the minimum to 2.26 then becareful to check it still works at that. The interaction of stuff that includes glib.h and others that include glib-compat.h was messy; I was working on the assumption that stuff that included glib-compat.h knew it was using newer things and didn't expect a warning; the problem that Peter pointed out was that glib-compat gets included by qemu-common so actually the warnings get disabled in loads of places. Dave >=20 > -- PMM -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK