From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39121) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlsMK-0006ad-On for qemu-devel@nongnu.org; Tue, 13 Oct 2015 01:42:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZlsMH-0002Eu-I0 for qemu-devel@nongnu.org; Tue, 13 Oct 2015 01:42:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45973) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlsMH-0002Eq-D5 for qemu-devel@nongnu.org; Tue, 13 Oct 2015 01:42:45 -0400 Date: Tue, 13 Oct 2015 08:42:37 +0300 From: "Michael S. Tsirkin" Message-ID: <20151013082734-mutt-send-email-mst@redhat.com> References: <1444535584-18220-1-git-send-email-guangrong.xiao@linux.intel.com> <1444535584-18220-24-git-send-email-guangrong.xiao@linux.intel.com> <20151012133853-mutt-send-email-mst@redhat.com> <561C92EE.60609@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <561C92EE.60609@linux.intel.com> Subject: Re: [Qemu-devel] [PATCH v3 23/32] nvdimm: build ACPI NFIT table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xiao Guangrong Cc: ehabkost@redhat.com, kvm@vger.kernel.org, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, imammedo@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net On Tue, Oct 13, 2015 at 01:13:18PM +0800, Xiao Guangrong wrote: > > > >> #endif > > > >This header is too small to be worth it. > >nvdimm_get_built_list seems to be the only interface - > >just stick it in the header you have under include. > > > > Other functions are introudced and included into it in later patches, > it includes the internal things shared between nvdimm device, nvdimm ACPI, > nvdimm namespace. > > Furthermore, this is a internal include file, it is not bad i think. Each time we do this, this seems to invite abuse where people add APIs without documenting them. I guess I could buy this if you add nvdimm_defs.h with just internal things such as layout of the buffer used for communication between ACPI and hardware. -- MST