From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43434)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZlskB-0004Rb-Lx
	for qemu-devel@nongnu.org; Tue, 13 Oct 2015 02:07:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Zlsk7-0000Cy-MH
	for qemu-devel@nongnu.org; Tue, 13 Oct 2015 02:07:27 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57141)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Zlsk7-0000Cu-Gs
	for qemu-devel@nongnu.org; Tue, 13 Oct 2015 02:07:23 -0400
Date: Tue, 13 Oct 2015 09:07:14 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20151013085854-mutt-send-email-mst@redhat.com>
References: <1444535584-18220-1-git-send-email-guangrong.xiao@linux.intel.com>
	<1444535584-18220-24-git-send-email-guangrong.xiao@linux.intel.com>
	<CAPcyv4hpRx-W5t2uDghdYzbwLsMjbXwZzeuRPVvukHynX5wVWg@mail.gmail.com>
	<561C93E0.6080602@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <561C93E0.6080602@linux.intel.com>
Subject: Re: [Qemu-devel] [PATCH v3 23/32] nvdimm: build ACPI NFIT table
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Cc: ehabkost@redhat.com, KVM list <kvm@vger.kernel.org>, Gleb Natapov <gleb@kernel.org>, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, imammedo@redhat.com, Paolo Bonzini <pbonzini@redhat.com>, Dan Williams <dan.j.williams@intel.com>, rth@twiddle.net

On Tue, Oct 13, 2015 at 01:17:20PM +0800, Xiao Guangrong wrote:
> >Would it worth including / copying the ACPICA header files directly?
> >
> >https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/acpi/actbl1.h
> >https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/acpi/acuuid.h
> 
> Good point, Dan.
> 
> These files are not exported under uapi/ so that it is not good to directly
> include it, i will learn the definition and adjust it to QEMU's code style
> in the next version.
> 
> Thanks!
> 

You can talk to acpica guys to try to move acuuid.h to uapi
if you like. But there's not a lot there that we need,
I'm not sure it's worth it.

-- 
MST