From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59403) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlxVv-0000JE-NU for qemu-devel@nongnu.org; Tue, 13 Oct 2015 07:13:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZlxVn-0001AV-Bu for qemu-devel@nongnu.org; Tue, 13 Oct 2015 07:13:03 -0400 Date: Tue, 13 Oct 2015 13:12:46 +0200 From: Kevin Wolf Message-ID: <20151013111246.GG4906@noname.str.redhat.com> References: <1444650651-26227-1-git-send-email-famz@redhat.com> <1444650651-26227-6-git-send-email-famz@redhat.com> <561BC33A.4030108@redhat.com> <20151013093142.GE4906@noname.str.redhat.com> <561CDF53.3020404@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <561CDF53.3020404@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 05/12] block: Introduce "drained begin/end" API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-block@nongnu.org, Fam Zheng , qemu-devel@nongnu.org, Stefan Hajnoczi Am 13.10.2015 um 12:39 hat Paolo Bonzini geschrieben: > > > On 13/10/2015 11:31, Kevin Wolf wrote: > > This would mean that once you've sent an I/O request inside a drain > > section, you have to expect that more internal I/O might be going on > > after the request has completed. If you don't want this, you have to > > issue another bdrv_drain() or use a nested bdrv_drained_begin/end() > > section. > > Yes. > > > Sounds reasonable enough to me, but I guess this should be explicitly > > documented. > > I agree. Perhaps bdrv_drained_begin/end() could be renamed to > bdrv_drain_and_lock() / bdrv_unlock()? It's not very obvious what bdrv_unlock() refers to, so I prefer the current naming. Just making sure that the comment for bdrv_drained_begin explains the exact semantics should be good enough. Kevin