From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50137) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlvCh-0007me-Do for qemu-devel@nongnu.org; Tue, 13 Oct 2015 04:45:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZlvCe-0008NO-5x for qemu-devel@nongnu.org; Tue, 13 Oct 2015 04:45:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45846) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlvCe-0008NC-11 for qemu-devel@nongnu.org; Tue, 13 Oct 2015 04:45:00 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 5C7F68C1B8 for ; Tue, 13 Oct 2015 08:44:57 +0000 (UTC) Date: Tue, 13 Oct 2015 11:44:53 +0300 From: "Michael S. Tsirkin" Message-ID: <20151013113142-mutt-send-email-mst@redhat.com> References: <1444663074-32617-1-git-send-email-marcel@redhat.com> <20151012183823-mutt-send-email-mst@redhat.com> <1444724017.19915.35.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444724017.19915.35.camel@redhat.com> Subject: Re: [Qemu-devel] [PATCH RFC] hw/virtio: Add PCIe capability to virtio devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Marcel Apfelbaum , qemu-devel@nongnu.org On Tue, Oct 13, 2015 at 10:13:37AM +0200, Gerd Hoffmann wrote: > On Mo, 2015-10-12 at 18:42 +0300, Michael S. Tsirkin wrote: > > On Mon, Oct 12, 2015 at 06:17:54PM +0300, Marcel Apfelbaum wrote: > > > The virtio devices are converted to PCI-Express > > > if they are plugged into a PCI-Express bus and > > > the 'modern' protocol is enabled. > > > > > > Signed-off-by: Marcel Apfelbaum > > > --- > > > > > > This is an RFC because all it does it adds the PCIe capability and nothing more. > > > > Express capability is easy. > > But if you go over express space you will see that a bunch of > > other capabilities are required, such as PM capability etc. > > These might need more work. > > Also what about the legacy io bar? I guess we'd better avoid that for > express devices. This needs some thought. We definitely still want a way to enable it I think, e.g. for old guests. > Maybe it makes sense to add virtio-*-pcie devices (virtio-1.0 only, with > pcie caps)? > > cheers, > Gerd Personally I think it's ugly enough to remember the need to specify -pci. OTOH the need to specify upstream and downstream ports is even uglier. Any idea how to address both issues at the same time? -- MST