From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48154) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlzAk-0005Tx-N5 for qemu-devel@nongnu.org; Tue, 13 Oct 2015 08:59:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZlzAh-0004GR-9j for qemu-devel@nongnu.org; Tue, 13 Oct 2015 08:59:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54404) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlzAh-0004GL-3z for qemu-devel@nongnu.org; Tue, 13 Oct 2015 08:59:15 -0400 Date: Tue, 13 Oct 2015 13:59:10 +0100 From: "Daniel P. Berrange" Message-ID: <20151013125910.GK18659@redhat.com> References: <1444739866-14798-1-git-send-email-berrange@redhat.com> <561CFEF6.3080603@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <561CFEF6.3080603@suse.de> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 0/7] qom: more efficient object property handling Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: Paolo Bonzini , Pavel Fedin , qemu-devel@nongnu.org, Markus Armbruster On Tue, Oct 13, 2015 at 02:54:14PM +0200, Andreas F=C3=A4rber wrote: > Daniel, >=20 > Am 13.10.2015 um 14:37 schrieb Daniel P. Berrange: > > This patch series is a followup to > >=20 > > v3: https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg02024.h= tml > > v2: https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg05953.h= tml > > + > > https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg01455.h= tml > >=20 > > This series introduces a concept of object property iterators > > to QOM so callers are insulated from the specific data structures > > used for storing properties against objects/classes. It then > > converts Object to use a GHashTable for storing properties. > > Finally it introduces ObjectClass properties. > >=20 > > Probably the only controversial thing is the item Pavel points > > out about object_child_foreach iterators now being forbidden > > from modifying the object composition tree. >=20 > Before this grows even larger, can't we just apply your v2 and go on > from there? I had reviewed that okay, just have it in my to-test queue.= .. I don't mind either way - if you want to queue my v2 I can rebase on top of that. Just beware though that my v2 had a latent bug that will trigger when any code starts to use class level properties - they don't get reported by QMP. So we'd have to make sure to apply this new series I have posted in order to fix that bug before we convert any code to use class props. Regards, Daniel --=20 |: http://berrange.com -o- http://www.flickr.com/photos/dberrange= / :| |: http://libvirt.org -o- http://virt-manager.or= g :| |: http://autobuild.org -o- http://search.cpan.org/~danberr= / :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vn= c :|