From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60425) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zlyig-0001YT-VM for qemu-devel@nongnu.org; Tue, 13 Oct 2015 08:30:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zlyic-0001fk-NG for qemu-devel@nongnu.org; Tue, 13 Oct 2015 08:30:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54235) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zlyic-0001fg-I4 for qemu-devel@nongnu.org; Tue, 13 Oct 2015 08:30:14 -0400 Date: Tue, 13 Oct 2015 14:30:10 +0200 From: Igor Mammedov Message-ID: <20151013143010.5fb8e5ea@nial.brq.redhat.com> In-Reply-To: <1444535584-18220-2-git-send-email-guangrong.xiao@linux.intel.com> References: <1444535584-18220-1-git-send-email-guangrong.xiao@linux.intel.com> <1444535584-18220-2-git-send-email-guangrong.xiao@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 01/32] acpi: add aml_derefof List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xiao Guangrong Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net On Sun, 11 Oct 2015 11:52:33 +0800 Xiao Guangrong wrote: > Implement DeRefOf term which is used by NVDIMM _DSM method in later patch > > Signed-off-by: Xiao Guangrong Reviewed-by: Igor Mammedov > --- > hw/acpi/aml-build.c | 8 ++++++++ > include/hw/acpi/aml-build.h | 1 + > 2 files changed, 9 insertions(+) > > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c > index 0d4b324..cbd53f4 100644 > --- a/hw/acpi/aml-build.c > +++ b/hw/acpi/aml-build.c > @@ -1135,6 +1135,14 @@ Aml *aml_unicode(const char *str) > return var; > } > > +/* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefDerefOf */ > +Aml *aml_derefof(Aml *arg) > +{ > + Aml *var = aml_opcode(0x83 /* DerefOfOp */); > + aml_append(var, arg); > + return var; > +} > + > void > build_header(GArray *linker, GArray *table_data, > AcpiTableHeader *h, const char *sig, int len, uint8_t rev) > diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h > index 1b632dc..5a03d33 100644 > --- a/include/hw/acpi/aml-build.h > +++ b/include/hw/acpi/aml-build.h > @@ -274,6 +274,7 @@ Aml *aml_create_dword_field(Aml *srcbuf, Aml *index, const char *name); > Aml *aml_varpackage(uint32_t num_elements); > Aml *aml_touuid(const char *uuid); > Aml *aml_unicode(const char *str); > +Aml *aml_derefof(Aml *arg); > > void > build_header(GArray *linker, GArray *table_data,