From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50277)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Zm1cc-0008AJ-0m
	for qemu-devel@nongnu.org; Tue, 13 Oct 2015 11:36:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Zm1cY-0008Qp-2k
	for qemu-devel@nongnu.org; Tue, 13 Oct 2015 11:36:13 -0400
Date: Tue, 13 Oct 2015 16:35:54 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20151013153554.GH3057@stefanha-thinkpad.redhat.com>
References: <cover.1443793122.git.berto@igalia.com>
	<21992a74e5b59e79abe92e243233054f615aa89a.1443793122.git.berto@igalia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <21992a74e5b59e79abe92e243233054f615aa89a.1443793122.git.berto@igalia.com>
Subject: Re: [Qemu-devel] [PATCH v2 05/22] block: Add idle_time_ns to
	BlockDeviceStats
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alberto Garcia <berto@igalia.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>

On Fri, Oct 02, 2015 at 05:26:15PM +0300, Alberto Garcia wrote:
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 5f12af7..a529e2f 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -448,6 +448,10 @@
>  # @wr_merged: Number of write requests that have been merged into another
>  #             request (Since 2.3).
>  #
> +# @idle_time_ns: #optional Time since the last I/O operation, in
> +#                miliseconds. If the field is absent it means that

s/miliseconds/nanoseconds/ ?

> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index 4f03d11..13c1bdc 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -2511,6 +2511,10 @@ Each json-object contain the following:
>                     another request (json-int)
>      - "wr_merged": number of write requests that have been merged into
>                     another request (json-int)
> +    - "idle_time_ns": time since the last I/O operation, in
> +                      miliseconds. If the field is absent it means

s/miliseconds/nanoseconds/ ?