From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52822) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zm1k7-0001J1-55 for qemu-devel@nongnu.org; Tue, 13 Oct 2015 11:43:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zm1k6-0002gM-9S for qemu-devel@nongnu.org; Tue, 13 Oct 2015 11:43:59 -0400 Date: Tue, 13 Oct 2015 16:43:48 +0100 From: Stefan Hajnoczi Message-ID: <20151013154348.GK3057@stefanha-thinkpad.redhat.com> References: <91b3bacda30ba46e1d2fa9e3801e0bd45629bf71.1443793122.git.berto@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <91b3bacda30ba46e1d2fa9e3801e0bd45629bf71.1443793122.git.berto@igalia.com> Subject: Re: [Qemu-devel] [PATCH v2 08/22] block: Allow configuring whether to account failed and invalid ops List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia Cc: Kevin Wolf , qemu-block@nongnu.org, Markus Armbruster , qemu-devel@nongnu.org, Max Reitz On Fri, Oct 02, 2015 at 05:26:18PM +0300, Alberto Garcia wrote: > This patch adds two options, "stats-account-invalid" and > "stats-account-failed", that can be used to decide whether invalid and > failed I/O operations must be used when collecting statistics for > latency and last access time. > > Signed-off-by: Alberto Garcia > --- > block/accounting.c | 24 +++++++++++++++++++----- > block/qapi.c | 3 +++ > blockdev.c | 16 ++++++++++++++++ > include/block/accounting.h | 5 +++++ > qapi/block-core.json | 17 ++++++++++++++++- > qmp-commands.hx | 25 ++++++++++++++++++++----- > 6 files changed, 79 insertions(+), 11 deletions(-) Reviewed-by: Stefan Hajnoczi