From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45394)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Zm0Ac-0006Nv-TB
	for qemu-devel@nongnu.org; Tue, 13 Oct 2015 10:03:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Zm0AZ-0001Zj-UX
	for qemu-devel@nongnu.org; Tue, 13 Oct 2015 10:03:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44745)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Zm0AZ-0001Zc-NW
	for qemu-devel@nongnu.org; Tue, 13 Oct 2015 10:03:11 -0400
Date: Tue, 13 Oct 2015 17:03:07 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20151013165956-mutt-send-email-mst@redhat.com>
References: <cover.1444737974.git.p.fedin@samsung.com>
	<20151013155711-mutt-send-email-mst@redhat.com>
	<014801d105bd$f4d8c5e0$de8a51a0$@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <014801d105bd$f4d8c5e0$de8a51a0$@samsung.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] Make KVM/MSI code device-ID-aware
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Fedin <p.fedin@samsung.com>
Cc: 'Paolo Bonzini' <pbonzini@redhat.com>, qemu-devel@nongnu.org

On Tue, Oct 13, 2015 at 04:49:17PM +0300, Pavel Fedin wrote:
>  Hello!
> 
> > I'm not at all sure we want to keep extending pci-assign with
> > more functionality. Why not add it to vfio instead?
> 
>  pci-assign? What exactly do you mean?
> 
>  hw/i386/kvm/pci-assign.c is modified only because kvm_irqchip_add_msi_route() now wants pci_dev pointer. Since x86 platform doesn't
> use device IDs, it could very well be NULL. Just i decided to keep it consistent with the rest of the code.
>  Actually, patch 0003 is all about that - we add pci_dev pointer to KVM GSI routing functions and make callers passing it, that's
> all.

I see, I didn't get that. Pls make this explicit in the commit log.

> Currently it's not used because KVM API is not released yet. See my full vITS patchset for information on how it will be used.
> And yes, the patchset is a bit obsolete, so it doesn't have msi_device_id() inline, there's copypasted calculation instead.
>  What exactly do you suggest to move to vfio?

msi_device_id seems like something kvm specific.
Maybe not vfio, just out of pci. 

> 
> Kind regards,
> Pavel Fedin
> Expert Engineer
> Samsung Electronics Research center Russia
>