From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53958)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <b.galvani@gmail.com>) id 1Zm4JK-0004FD-Kg
	for qemu-devel@nongnu.org; Tue, 13 Oct 2015 14:28:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <b.galvani@gmail.com>) id 1Zm4JF-0001l9-LH
	for qemu-devel@nongnu.org; Tue, 13 Oct 2015 14:28:30 -0400
Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:36665)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <b.galvani@gmail.com>) id 1Zm4JF-0001l4-F5
	for qemu-devel@nongnu.org; Tue, 13 Oct 2015 14:28:25 -0400
Received: by wicgb1 with SMTP id gb1so200304427wic.1
	for <qemu-devel@nongnu.org>; Tue, 13 Oct 2015 11:28:25 -0700 (PDT)
Date: Tue, 13 Oct 2015 20:28:14 +0200
From: Beniamino Galvani <b.galvani@gmail.com>
Message-ID: <20151013182814.GA4175@gmail.com>
References: <cover.1444448892.git.crosthwaite.peter@gmail.com>
	<eda3f569d6f605bc985a88fc3d9be7fca380a780.1444448892.git.crosthwaite.peter@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <eda3f569d6f605bc985a88fc3d9be7fca380a780.1444448892.git.crosthwaite.peter@gmail.com>
Subject: Re: [Qemu-devel] [RFC 3/4] ahci: Add allwinner AHCI
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>
Cc: jsnow@redhat.com, qemu-devel@nongnu.org, Peter Crosthwaite <crosthwaite.peter@gmail.com>

On Sun, Oct 11, 2015 at 09:21:35AM -0700, Peter Crosthwaite wrote:
> --- a/hw/ide/ahci.c
> +++ b/hw/ide/ahci.c
> @@ -1692,9 +1692,107 @@ static const TypeInfo sysbus_ahci_info = {
>      .class_init    = sysbus_ahci_class_init,
>  };
>  
> +#define ALLWINNER_AHCI_MMIO_OFF  0x80
> +#define ALLWINNER_AHCI_MMIO_SIZE 0x80

These are already defined in the header file.

> +static const VMStateDescription vmstate_allwinner_ahci = {
> +    .name = "a10.pic",

.name = "allwinner-ahci" ?

Beniamino