From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48468) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmNVW-0006qw-IE for qemu-devel@nongnu.org; Wed, 14 Oct 2015 10:58:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZmNVR-0007X0-DP for qemu-devel@nongnu.org; Wed, 14 Oct 2015 10:58:22 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:38187) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmNVR-0007Wm-8K for qemu-devel@nongnu.org; Wed, 14 Oct 2015 10:58:17 -0400 Received: by wieq12 with SMTP id q12so87214359wie.1 for ; Wed, 14 Oct 2015 07:58:16 -0700 (PDT) Date: Wed, 14 Oct 2015 16:58:13 +0200 From: Eduardo Otubo Message-ID: <20151014145813.GA5261@vader> References: <1435756353-4150-1-git-send-email-drjones@redhat.com> <20150924093119.GA11859@vader> <20150924135004.GC3486@hawk.localdomain> <20150929093946.GA30238@vader> <20151014090337.GA13329@vader> <20151014124118.GA24085@hawk.localdomain> <87eggxzioj.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7AUc2qLy4jB3hD7Z" Content-Disposition: inline In-Reply-To: <87eggxzioj.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH] libseccomp: add cacheflush to whitelist List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: pmoore@redhat.com, peter.maydell@linaro.org, Andrew Jones , qemu-devel@nongnu.org --7AUc2qLy4jB3hD7Z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 14, 2015 at 03=3D25=3D00PM +0200, Markus Armbruster wrote: > Andrew Jones writes: >=20 > > On Wed, Oct 14, 2015 at 11:03:37AM +0200, Eduardo Otubo wrote: > >> On Tue, Sep 29, 2015 at 11=3D39=3D46AM +0200, Eduardo Otubo wrote: > >> > On Thu, Sep 24, 2015 at 03=3D50=3D04PM +0200, Andrew Jones wrote: > >> > > On Thu, Sep 24, 2015 at 11:31:19AM +0200, Eduardo Otubo wrote: > >> > > > On Wed, Jul 01, 2015 at 09=3D12=3D33AM -0400, Andrew Jones wrote: > [...] > >> > > > > diff --git a/qemu-seccomp.c b/qemu-seccomp.c > >> > > > > index f9de0d3390feb..33644a4e3c3d3 100644 > >> > > > > --- a/qemu-seccomp.c > >> > > > > +++ b/qemu-seccomp.c > >> > > > > @@ -237,7 +237,8 @@ static const struct QemuSeccompSyscall sec= comp_whitelist[] =3D { > >> > > > > { SCMP_SYS(fadvise64), 240 }, > >> > > > > { SCMP_SYS(inotify_init1), 240 }, > >> > > > > { SCMP_SYS(inotify_add_watch), 240 }, > >> > > > > - { SCMP_SYS(mbind), 240 } > >> > > > > + { SCMP_SYS(mbind), 240 }, > >> > > > > + { SCMP_SYS(cacheflush), 240 }, > >>=20 > >> FYI: I had to fixed this minor mistake (using comma at the end of the > >> list) before applying your patch. > > > > Does that violate a QEMU coding style? Because I actually put it there > > on purpose so the next addition wouldn't have to modify the line (by > > adding a comma), making git-blame more difficult to use. >=20 > We have trailing commas all over the place, for precisely the reason you > gave. I recommend to put it right back. >=20 Well, that makes a lot of sense. I'll just put it back again and send the pull request once more. ps.: I just thought the guideline said to make sure every commit should be "compilable" with no errors, perhaps I saw it somewhere else. Sorry for the trouble. --=20 Eduardo Otubo ProfitBricks GmbH --7AUc2qLy4jB3hD7Z Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWHm2FAAoJEP0M/1sS+L0vUK4H/RuPoIwYobL+lmNc5bYKAa92 qy6LoSPzDh4jTDb51QU8LxBtC8skPsOJjHQ0p4HOEAJIrTlPfx0jpHZSx+eKjluz +xPfvABA9dB/eIKR60A+3vDtHltgXLnd9qOM3ay/47JceeSQ0Pr9xMgB+zhHsrwk qadrOH6hpWyV13wbywMnIROtHve4b0JrteXMkyEp09wkuOUkzolVwzcV+XNvF8Eb XGPkBW3EO7S6YVcmEcweTGdZxzSWbDXjjNm/FxLaNVzf5ppD2h8KNmJr/QuAw10e d6p+CIew+gguTXQHzzOI6kVrDPe1sat3MFLOoEPgjLAmcTd4phLaWtC8QyaO0Rw= =hHMC -----END PGP SIGNATURE----- --7AUc2qLy4jB3hD7Z--