From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33354)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZmKiF-00061z-BE
	for qemu-devel@nongnu.org; Wed, 14 Oct 2015 07:59:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZmKiC-0002L1-3n
	for qemu-devel@nongnu.org; Wed, 14 Oct 2015 07:59:19 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34847)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZmKiB-0002Kw-VL
	for qemu-devel@nongnu.org; Wed, 14 Oct 2015 07:59:16 -0400
Date: Wed, 14 Oct 2015 14:59:11 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20151014145852-mutt-send-email-mst@redhat.com>
References: <cover.1444808892.git.p.fedin@samsung.com>
	<20151014112515-mutt-send-email-mst@redhat.com>
	<00d201d1065c$c1f1eb30$45d5c190$@samsung.com>
	<20151014133313-mutt-send-email-mst@redhat.com>
	<013d01d10676$59b7cb60$0d276220$@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <013d01d10676$59b7cb60$0d276220$@samsung.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/3] Make KVM/MSI code device-ID-aware
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Fedin <p.fedin@samsung.com>
Cc: 'Peter Maydell' <peter.maydell@linaro.org>, qemu-devel@nongnu.org, 'Paolo Bonzini' <pbonzini@redhat.com>

On Wed, Oct 14, 2015 at 02:49:14PM +0300, Pavel Fedin wrote:
>  Hello!
> 
> > OK, so we could rename stream id to requester id. That at least would
> > make sense at the pci level, and would make it unique per hierarchy.
> 
>  Yes, we can, i'm fine with the rename. Additionally, "requester ID" is the official term used in GICv3 architecture manual. When i
> implemented it i didn't have arch manual, therefore had to invent the name.
> 
> > But I suspect all these optimizations break later when we need to support
> > multiple root complex devices.
> 
>  Not necessarily. IIRC we have three bits used for other purposes in MemTxAttrs. So, we could extend our RID up to 24 bits and still
> be fine. Even if we use 32 bits, our MemTxAttrs would still fit into register on 64-bit platforms, and into two registers on 32-bit
> platforms. The same as MSIMessage (don't remember exact name).
> 
>  Should i post v3, including the rename, or will you just rename stream_id to requester_id yourself?
> 
> Kind regards,
> Pavel Fedin
> Expert Engineer
> Samsung Electronics Research center Russia


Pls do it.

-- 
MST