From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54721)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1ZmNjp-0001wS-AH
	for qemu-devel@nongnu.org; Wed, 14 Oct 2015 11:13:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1ZmNjj-0004Hb-C3
	for qemu-devel@nongnu.org; Wed, 14 Oct 2015 11:13:08 -0400
Date: Wed, 14 Oct 2015 17:12:50 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20151014151250.GD16803@noname.str.redhat.com>
References: <1444680042-13207-1-git-send-email-mreitz@redhat.com>
	<1444680042-13207-26-git-send-email-mreitz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1444680042-13207-26-git-send-email-mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6 25/39] blockdev: Pull out blockdev
	option extraction
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: Alberto Garcia <berto@igalia.com>, qemu-block@nongnu.org, John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

Am 12.10.2015 um 22:00 hat Max Reitz geschrieben:
> Extract some of the blockdev option extraction code from blockdev_init()
> into its own function. This simplifies blockdev_init() and will allow
> reusing the code in a different function added in a follow-up patch.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> Reviewed-by: Alberto Garcia <berto@igalia.com>

Reviewed-by: Kevin Wolf <kwolf@redhat.com>

> +#ifdef CONFIG_LINUX_AIO
> +    if ((aio = qemu_opt_get(opts, "aio")) != NULL) {
> +        if (!strcmp(aio, "native")) {
> +            *bdrv_flags |= BDRV_O_NATIVE_AIO;
> +        } else if (!strcmp(aio, "threads")) {
> +            /* this is the default */
> +        } else {
> +           error_setg(errp, "invalid aio option");
> +           return;
> +        }
> +    }
> +#endif

Unrelated to your patch, but didn't we want to remove this #ifdef? I
thought we had already done so... Oh, I've never flushed block-next
after the 2.4 release. :-/

Expect a merge conflict coming up here...

Kevin