From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34812)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1ZmP0p-0005tu-Cg
	for qemu-devel@nongnu.org; Wed, 14 Oct 2015 12:34:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1ZmP0m-0001IE-6h
	for qemu-devel@nongnu.org; Wed, 14 Oct 2015 12:34:47 -0400
Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:51489)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1ZmP0l-0001HV-VR
	for qemu-devel@nongnu.org; Wed, 14 Oct 2015 12:34:44 -0400
Date: Wed, 14 Oct 2015 18:34:40 +0200
From: Samuel Thibault <samuel.thibault@gnu.org>
Message-ID: <20151014163440.GY2609@var.bordeaux.inria.fr>
References: <1444637004-20195-1-git-send-email-pbonzini@redhat.com>
	<1444637004-20195-15-git-send-email-pbonzini@redhat.com>
	<561BD204.7050307@redhat.com>
	<20151012154135.GF4886@var.bordeaux.inria.fr>
	<561E7A17.6050906@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <561E7A17.6050906@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 14/21] qemu-char: convert braille backend
 to data-driven creation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com

Paolo Bonzini, le Wed 14 Oct 2015 17:51:51 +0200, a écrit :
> 
> 
> On 12/10/2015 17:41, Samuel Thibault wrote:
> > Eric Blake, le Mon 12 Oct 2015 09:30:12 -0600, a écrit :
> >>  Also, I assume that brlapi_perror() adds additional information to
> >> the error message it prints, such as conversion of a brlapi-specific
> >> error message in the same manner in which perror() converts errno and in
> >> which error_setg_errno() would be used.
> > 
> > Yes. Such additional information is really useful to debug brlapi
> > issues.
> > 
> >> So I don't know if this
> >> conversion is the best.  But I'm unfamiliar with brlapi_* in general, to
> >> know if there is anything better to use,
> > 
> > brlapi_error_t * brlapi_error_location(void);
> > const char * brlapi_strerror(const brlapi_error_t *error);
> > 
> > So brlapi_strerror(brlapi_error_location()) will return what you want,
> > i.e. the string that brlapi_error() would have printed.
> 
> Is it okay to squash this?

Yes, this looks right. Building with brlapi-dev installed would confirm
for sure that it builds, of course :)

Samuel