From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58430) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmQ4c-0003wt-Do for qemu-devel@nongnu.org; Wed, 14 Oct 2015 13:42:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZmQ4b-0008VV-HM for qemu-devel@nongnu.org; Wed, 14 Oct 2015 13:42:46 -0400 Date: Wed, 14 Oct 2015 13:42:38 -0400 From: Jeff Cody Message-ID: <20151014174238.GA6107@localhost.localdomain> References: <561E910C.2090204@redhat.com> <561E9233.8090207@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <561E9233.8090207@redhat.com> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 1/3] block: Use bdrv_lookup_bs() instead of bdrv_find_node() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: kwolf@redhat.com, quintela@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org, armbru@redhat.com On Wed, Oct 14, 2015 at 07:34:43PM +0200, Max Reitz wrote: > On 14.10.2015 19:29, Max Reitz wrote: > > On 14.10.2015 15:16, Jeff Cody wrote: > >> This is a precursor to making bdrv_find_node() static, and internal > >> to block.c > >> > >> To find a BlockDriverState interface, it can be done via blk_by_name(), > >> bdrv_find_node(), and bdrv_lookup_bs(). The latter can take the place > >> of the other two, in the instances where we are only concerned with > >> the BlockDriverState. > >> > >> There is no benefit in calling bdrv_find_node() directly. This patch > >> replaces all calls to bdrv_find_node() outside of block.c with > >> bdrv_lookup_bs(). > >> > >> Signed-off-by: Jeff Cody > >> --- > >> block/block-backend.c | 2 +- > >> block/mirror.c | 2 +- > >> block/write-threshold.c | 2 +- > >> 3 files changed, 3 insertions(+), 3 deletions(-) > > > > Reviewed-by: Max Reitz > > Oh, wait, on patch 2 gcc tells me I should take that back. If this > series is based on Berto's series, that means it's also based on my > BlockBackend series, and that one adds another instance of bdrv_find_node(). > > Since I'll have to send a v7 anyway, I'll make it a bdrv_lookup_bs() > there, so my R-b stands. > > Max > Thanks. I actually managed to apply Berto's without yours, but I just went back and rectified that, and applied yours. Jeff