From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37455) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zml8t-000149-3L for qemu-devel@nongnu.org; Thu, 15 Oct 2015 12:12:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zml8n-0003pk-Vw for qemu-devel@nongnu.org; Thu, 15 Oct 2015 12:12:35 -0400 Date: Thu, 15 Oct 2015 17:12:25 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20151015161224.GD2598@work-vm> References: <1444890480-6371-1-git-send-email-quintela@redhat.com> <1444890480-6371-2-git-send-email-quintela@redhat.com> <561FC11E.1000206@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <561FC11E.1000206@de.ibm.com> Subject: Re: [Qemu-devel] [PULL 1/3] Migration: Generate the completed event only when we complete List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger Cc: amit.shah@redhat.com, qemu-stable@nongnu.org, qemu-devel@nongnu.org, Juan Quintela * Christian Borntraeger (borntraeger@de.ibm.com) wrote: > Am 15.10.2015 um 08:27 schrieb Juan Quintela: > > From: "Dr. David Alan Gilbert" > > > > The current migration-completed event is generated a bit too early, > > which means that an eager libvirt that's ready to go as soon > > as it sees the event ends up racing with the actual end of migration. > > > > This corresponds to RH bug: > > https://bugzilla.redhat.com/show_bug.cgi?id=1271145 > > Is that something for stable? Hmm, yes, it probably should be. cc'd in. Dave > > > > > > Signed-off-by: Dr. David Alan Gilbert > > Reviewed-by: Juan Quintela > > Reviewed-by: Amit Shah > > xSigned-off-by: Juan Quintela > > > > --- > > migration/migration.c | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/migration/migration.c b/migration/migration.c > > index b7de9b7..3d40f24 100644 > > --- a/migration/migration.c > > +++ b/migration/migration.c > > @@ -294,12 +294,12 @@ static void process_incoming_migration_co(void *opaque) > > migrate_decompress_threads_join(); > > exit(EXIT_FAILURE); > > } > > - migrate_generate_event(MIGRATION_STATUS_COMPLETED); > > qemu_announce_self(); > > > > /* Make sure all file formats flush their mutable metadata */ > > bdrv_invalidate_cache_all(&local_err); > > if (local_err) { > > + migrate_generate_event(MIGRATION_STATUS_FAILED); > > error_report_err(local_err); > > migrate_decompress_threads_join(); > > exit(EXIT_FAILURE); > > @@ -320,6 +320,12 @@ static void process_incoming_migration_co(void *opaque) > > runstate_set(global_state_get_runstate()); > > } > > migrate_decompress_threads_join(); > > + /* > > + * This must happen after any state changes since as soon as an external > > + * observer sees this event they might start to prod at the VM assuming > > + * it's ready to use. > > + */ > > + migrate_generate_event(MIGRATION_STATUS_COMPLETED); > > } > > > > void process_incoming_migration(QEMUFile *f) > > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK