From: Stefan Hajnoczi <stefanha@redhat.com>
To: Alberto Garcia <berto@igalia.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v8 03/11] block: never cancel a streaming job without running stream_complete()
Date: Fri, 16 Oct 2015 10:35:26 +0200 [thread overview]
Message-ID: <20151016083526.GA7994@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <d575a576c18d8972ac1a200c4022b39cbbce2507.1435008395.git.berto@igalia.com>
On Tue, Jun 23, 2015 at 12:32:18AM +0300, Alberto Garcia wrote:
> We need to call stream_complete() in order to do all the necessary
> clean-ups, even if there's an early failure. At the moment it's only
> useful to make sure that s->backing_file_str is not leaked, but it
> will become more important as we introduce support for streaming to
> any intermediate node.
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> Reviewed-by: Max Reitz <mreitz@redhat.com>
> ---
> block/stream.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
next prev parent reply other threads:[~2015-10-16 8:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-22 21:32 [Qemu-devel] [PATCH v8 00/11] Support streaming to an intermediate layer Alberto Garcia
2015-06-22 21:32 ` [Qemu-devel] [PATCH v8 01/11] block: keep a list of block jobs Alberto Garcia
2015-06-24 15:45 ` Max Reitz
2015-06-22 21:32 ` [Qemu-devel] [PATCH v8 02/11] block: allow block jobs in any arbitrary node Alberto Garcia
2015-06-22 21:32 ` [Qemu-devel] [PATCH v8 03/11] block: never cancel a streaming job without running stream_complete() Alberto Garcia
2015-10-16 8:35 ` Stefan Hajnoczi [this message]
2015-06-22 21:32 ` [Qemu-devel] [PATCH v8 04/11] block: Support streaming to an intermediate layer Alberto Garcia
2015-06-22 21:32 ` [Qemu-devel] [PATCH v8 05/11] block: Add QMP support for " Alberto Garcia
2015-06-22 21:32 ` [Qemu-devel] [PATCH v8 06/11] docs: Document how to stream " Alberto Garcia
2015-06-22 21:32 ` [Qemu-devel] [PATCH v8 07/11] qemu-iotests: fix test_stream_partial() Alberto Garcia
2015-06-22 21:32 ` [Qemu-devel] [PATCH v8 08/11] qemu-iotests: add no-op streaming test Alberto Garcia
2015-06-22 21:32 ` [Qemu-devel] [PATCH v8 09/11] qemu-iotests: test streaming to an intermediate layer Alberto Garcia
2015-06-22 21:32 ` [Qemu-devel] [PATCH v8 10/11] qemu-iotests: test block-stream operations in parallel Alberto Garcia
2015-06-22 21:32 ` [Qemu-devel] [PATCH v8 11/11] qemu-iotests: test overlapping block-stream operations Alberto Garcia
2015-06-23 15:36 ` [Qemu-devel] [PATCH v8 00/11] Support streaming to an intermediate layer Stefan Hajnoczi
2015-06-23 16:09 ` Alberto Garcia
2015-06-23 16:48 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2015-06-24 8:02 ` Alberto Garcia
2015-06-24 10:02 ` Alberto Garcia
2015-06-26 8:01 ` Alberto Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151016083526.GA7994@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=berto@igalia.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).