From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60406)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Zn17j-0002QZ-G2
	for qemu-devel@nongnu.org; Fri, 16 Oct 2015 05:16:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Zn17X-0001h1-7S
	for qemu-devel@nongnu.org; Fri, 16 Oct 2015 05:16:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40704)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Zn17X-0001gv-2K
	for qemu-devel@nongnu.org; Fri, 16 Oct 2015 05:16:15 -0400
Date: Fri, 16 Oct 2015 11:16:12 +0200
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20151016091612.GF7432@stefanha-thinkpad.redhat.com>
References: <20151013171020.21325.27626.stgit@localhost>
	<20151013171032.21325.61781.stgit@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <20151013171032.21325.61781.stgit@localhost>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCHv12/8] trace: Add 'vcpu' event property
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-1?Q?Llu=EDs?= Vilanova <vilanova@ac.upc.edu>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org

On Tue, Oct 13, 2015 at 07:10:33PM +0200, Llu=EDs Vilanova wrote:
> diff --git a/scripts/tracetool/format/h.py b/scripts/tracetool/format/h=
.py
> index 9b39430..4bdb48f 100644
> --- a/scripts/tracetool/format/h.py
> +++ b/scripts/tracetool/format/h.py
> @@ -6,7 +6,7 @@ trace/generated-tracers.h
>  """
> =20
>  __author__     =3D "Llu=EDs Vilanova <vilanova@ac.upc.edu>"
> -__copyright__  =3D "Copyright 2012-2014, Llu=EDs Vilanova <vilanova@ac=
.upc.edu>"
> +__copyright__  =3D "Copyright 2012-2015, Llu=EDs Vilanova <vilanova@ac=
.upc.edu>"
>  __license__    =3D "GPL version 2 or (at your option) any later versio=
n"
> =20
>  __maintainer__ =3D "Stefan Hajnoczi"
> @@ -23,6 +23,8 @@ def generate(events, backend):
>          '#define TRACE__GENERATED_TRACERS_H',
>          '',
>          '#include "qemu-common.h"',
> +        '',
> +        'typedef struct CPUState CPUState;',

Here...

> diff --git a/scripts/tracetool/format/ust_events_c.py b/scripts/traceto=
ol/format/ust_events_c.py
> index bc97093..92064f0 100644
> --- a/scripts/tracetool/format/ust_events_c.py
> +++ b/scripts/tracetool/format/ust_events_c.py
> @@ -6,7 +6,7 @@ trace/generated-ust.c
>  """
> =20
>  __author__     =3D "Mohamad Gebai <mohamad.gebai@polymtl.ca>"
> -__copyright__  =3D "Copyright 2012, Mohamad Gebai <mohamad.gebai@polym=
tl.ca>"
> +__copyright__  =3D "Copyright 2012, 2015, Mohamad Gebai <mohamad.gebai=
@polymtl.ca>"
>  __license__    =3D "GPL version 2 or (at your option) any later versio=
n"
> =20
>  __maintainer__ =3D "Stefan Hajnoczi"
> @@ -30,4 +30,6 @@ def generate(events, backend):
>          ' */',
>          '#pragma GCC diagnostic ignored "-Wredundant-decls"',
>          '',
> +        'typedef struct CPUState CPUState;',
> +        '',
>          '#include "generated-ust-provider.h"')

...and here is okay but please generate a comment so it's clear why this
needs to be defined.