From: Stefan Hajnoczi <stefanha@gmail.com>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH] piix: fix resource leak reported by Coverity
Date: Fri, 16 Oct 2015 14:01:15 +0200 [thread overview]
Message-ID: <20151016120115.GC10205@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1442227210-24604-1-git-send-email-zhang.zhanghailiang@huawei.com>
On Mon, Sep 14, 2015 at 06:40:10PM +0800, zhanghailiang wrote:
> config_fd should be closed before return, or there will
> be a resource leak error.
>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> ---
> hw/pci-host/piix.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
next prev parent reply other threads:[~2015-10-16 12:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 10:40 [Qemu-devel] [PATCH] piix: fix resource leak reported by Coverity zhanghailiang
2015-10-16 12:01 ` Stefan Hajnoczi [this message]
2015-10-29 7:40 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151016120115.GC10205@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).