* [Qemu-devel] [PATCH] blkdebug: Don't confuse image as backing file
@ 2015-10-16 10:46 Fam Zheng
2015-10-16 12:29 ` Eric Blake
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Fam Zheng @ 2015-10-16 10:46 UTC (permalink / raw)
To: qemu-devel; +Cc: Kevin Wolf, qemu-block
The word "backing file" nowadays refers to the backing_hd in the
external snapshot sense (i.e. bs->backing_hd), instead of the file sense
(bs->file). Correct the comment to use the right term.
Signed-off-by: Fam Zheng <famz@redhat.com>
---
block/blkdebug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blkdebug.c b/block/blkdebug.c
index bc247f4..54650a7 100644
--- a/block/blkdebug.c
+++ b/block/blkdebug.c
@@ -426,7 +426,7 @@ static int blkdebug_open(BlockDriverState *bs, QDict *options, int flags,
/* Set initial state */
s->state = 1;
- /* Open the backing file */
+ /* Open the image file */
assert(bs->file == NULL);
ret = bdrv_open_image(&bs->file, qemu_opt_get(opts, "x-image"), options, "image",
bs, &child_file, false, &local_err);
--
2.4.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] blkdebug: Don't confuse image as backing file
2015-10-16 10:46 [Qemu-devel] [PATCH] blkdebug: Don't confuse image as backing file Fam Zheng
@ 2015-10-16 12:29 ` Eric Blake
2015-10-16 12:50 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2015-10-16 13:36 ` [Qemu-devel] " Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Eric Blake @ 2015-10-16 12:29 UTC (permalink / raw)
To: Fam Zheng, qemu-devel; +Cc: Kevin Wolf, qemu-block
[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]
On 10/16/2015 04:46 AM, Fam Zheng wrote:
> The word "backing file" nowadays refers to the backing_hd in the
> external snapshot sense (i.e. bs->backing_hd), instead of the file sense
> (bs->file). Correct the comment to use the right term.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> block/blkdebug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/block/blkdebug.c b/block/blkdebug.c
> index bc247f4..54650a7 100644
> --- a/block/blkdebug.c
> +++ b/block/blkdebug.c
> @@ -426,7 +426,7 @@ static int blkdebug_open(BlockDriverState *bs, QDict *options, int flags,
> /* Set initial state */
> s->state = 1;
>
> - /* Open the backing file */
> + /* Open the image file */
> assert(bs->file == NULL);
> ret = bdrv_open_image(&bs->file, qemu_opt_get(opts, "x-image"), options, "image",
> bs, &child_file, false, &local_err);
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] blkdebug: Don't confuse image as backing file
2015-10-16 10:46 [Qemu-devel] [PATCH] blkdebug: Don't confuse image as backing file Fam Zheng
2015-10-16 12:29 ` Eric Blake
@ 2015-10-16 12:50 ` Alberto Garcia
2015-10-16 13:36 ` [Qemu-devel] " Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Alberto Garcia @ 2015-10-16 12:50 UTC (permalink / raw)
To: Fam Zheng, qemu-devel; +Cc: Kevin Wolf, qemu-block
On Fri 16 Oct 2015 12:46:04 PM CEST, Fam Zheng wrote:
> The word "backing file" nowadays refers to the backing_hd in the
> external snapshot sense (i.e. bs->backing_hd), instead of the file sense
> (bs->file). Correct the comment to use the right term.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Berto
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] blkdebug: Don't confuse image as backing file
2015-10-16 10:46 [Qemu-devel] [PATCH] blkdebug: Don't confuse image as backing file Fam Zheng
2015-10-16 12:29 ` Eric Blake
2015-10-16 12:50 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
@ 2015-10-16 13:36 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Kevin Wolf @ 2015-10-16 13:36 UTC (permalink / raw)
To: Fam Zheng; +Cc: qemu-devel, qemu-block
Am 16.10.2015 um 12:46 hat Fam Zheng geschrieben:
> The word "backing file" nowadays refers to the backing_hd in the
> external snapshot sense (i.e. bs->backing_hd), instead of the file sense
> (bs->file). Correct the comment to use the right term.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-16 13:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-16 10:46 [Qemu-devel] [PATCH] blkdebug: Don't confuse image as backing file Fam Zheng
2015-10-16 12:29 ` Eric Blake
2015-10-16 12:50 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2015-10-16 13:36 ` [Qemu-devel] " Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).