From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35506) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZnsiK-00054K-Vb for qemu-devel@nongnu.org; Sun, 18 Oct 2015 14:29:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZnsiH-0006Ui-PS for qemu-devel@nongnu.org; Sun, 18 Oct 2015 14:29:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55160) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZnsiH-0006Ue-Ju for qemu-devel@nongnu.org; Sun, 18 Oct 2015 14:29:45 -0400 Date: Sun, 18 Oct 2015 20:29:40 +0200 From: Andrew Jones Message-ID: <20151018182940.GD12158@hawk.localdomain> References: <5612EDA5.9010506@redhat.com> <1444662470-13045-1-git-send-email-cov@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444662470-13045-1-git-send-email-cov@codeaurora.org> Subject: Re: [Qemu-devel] [kvm-unit-tests PATCHv4] ARM PMU tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christopher Covington Cc: wei@redhat.com, alindsay@codeaurora.org, kvm@vger.kernel.org, croberts@codeaurora.org, qemu-devel@nongnu.org, alistair.francis@xilinx.com, shannon.zhao@linaro.org, kvmarm@lists.cs.columbia.edu On Mon, Oct 12, 2015 at 11:07:47AM -0400, Christopher Covington wrote: > Changes from v3 in response to Drew's suggestions: > > * Improved pmu_data / PMCR fields and usage > * Straightened out awkward conditionals > * Added 32-bit support > * Styling enhancements > * Deferred -icount testing to later patch > > Sorry I was slow to review this version. Also, just FYI, I'll be on vacation for a week, so I'll probably be slow to review the next version too :-) Anyway, thanks for the patches, and thanks for your patience. drew