From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47736) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZnrZy-0001Bj-TK for qemu-devel@nongnu.org; Sun, 18 Oct 2015 13:17:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZnrZu-0005Aw-QY for qemu-devel@nongnu.org; Sun, 18 Oct 2015 13:17:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59479) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZnrZu-0005AI-Lg for qemu-devel@nongnu.org; Sun, 18 Oct 2015 13:17:02 -0400 Date: Sun, 18 Oct 2015 20:16:57 +0300 From: "Michael S. Tsirkin" Message-ID: <20151018201620-mutt-send-email-mst@redhat.com> References: <1445216059-88521-1-git-send-email-guangrong.xiao@linux.intel.com> <1445216059-88521-28-git-send-email-guangrong.xiao@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1445216059-88521-28-git-send-email-guangrong.xiao@linux.intel.com> Subject: Re: [Qemu-devel] [PATCH v4 27/33] nvdimm acpi: save arg3 for NVDIMM device _DSM method List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xiao Guangrong Cc: ehabkost@redhat.com, kvm@vger.kernel.org, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, imammedo@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net On Mon, Oct 19, 2015 at 08:54:13AM +0800, Xiao Guangrong wrote: > Check if the input Arg3 is valid then store it into dsm_in if needed > > Signed-off-by: Xiao Guangrong > --- > hw/acpi/nvdimm.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c > index 7e99889..b211b8b 100644 > --- a/hw/acpi/nvdimm.c > +++ b/hw/acpi/nvdimm.c > @@ -624,10 +624,29 @@ static void nvdimm_build_acpi_devices(NVDIMMState *state, GSList *device_list, > > method = aml_method_serialized("NCAL", 4); > { > + Aml *ifctx; > + > aml_append(method, aml_store(aml_arg(0), aml_name("HDLE"))); > aml_append(method, aml_store(aml_arg(1), aml_name("REVS"))); > aml_append(method, aml_store(aml_arg(2), aml_name("FUNC"))); > > + /* Arg3 is passed as Package and it has one element? */ > + ifctx = aml_if(aml_and(aml_equal(aml_object_type(aml_arg(3)), > + aml_int(4)), > + aml_equal(aml_sizeof(aml_arg(3)), > + aml_int(1)))); > + { > + /* Local0 = Index(Arg3, 0) */ > + aml_append(ifctx, aml_store(aml_index(aml_arg(3), aml_int(0)), > + aml_local(0))); > + /* Local3 = DeRefOf(Local0) */ > + aml_append(ifctx, aml_store(aml_derefof(aml_local(0)), > + aml_local(3))); > + /* ARG3 = Local3 */ > + aml_append(ifctx, aml_store(aml_local(3), aml_name("ARG3"))); > + } > + aml_append(method, ifctx); > + > aml_append(method, aml_store(aml_int(NOTIFY_VALUE), aml_name("NOTI"))); > > aml_append(method, aml_store(aml_name("RLEN"), aml_local(6))); I commented on this patch on v3. It doesn't look like this was addressed. > -- > 1.8.3.1