From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52258) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zo4OP-0004M6-W7 for qemu-devel@nongnu.org; Mon, 19 Oct 2015 02:58:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zo4OM-0004dH-0C for qemu-devel@nongnu.org; Mon, 19 Oct 2015 02:58:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48588) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zo4OL-0004cr-Pe for qemu-devel@nongnu.org; Mon, 19 Oct 2015 02:57:57 -0400 Date: Mon, 19 Oct 2015 09:57:53 +0300 From: "Michael S. Tsirkin" Message-ID: <20151019094835-mutt-send-email-mst@redhat.com> References: <1445216059-88521-1-git-send-email-guangrong.xiao@linux.intel.com> <1445216059-88521-28-git-send-email-guangrong.xiao@linux.intel.com> <20151018201620-mutt-send-email-mst@redhat.com> <56246BE0.2040901@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56246BE0.2040901@linux.intel.com> Subject: Re: [Qemu-devel] [PATCH v4 27/33] nvdimm acpi: save arg3 for NVDIMM device _DSM method List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xiao Guangrong Cc: ehabkost@redhat.com, kvm@vger.kernel.org, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, imammedo@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net On Mon, Oct 19, 2015 at 12:04:48PM +0800, Xiao Guangrong wrote: > > > On 10/19/2015 01:16 AM, Michael S. Tsirkin wrote: > >On Mon, Oct 19, 2015 at 08:54:13AM +0800, Xiao Guangrong wrote: > >>Check if the input Arg3 is valid then store it into dsm_in if needed > >> > >>Signed-off-by: Xiao Guangrong > >>--- > >> hw/acpi/nvdimm.c | 19 +++++++++++++++++++ > >> 1 file changed, 19 insertions(+) > >> > >>diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c > >>index 7e99889..b211b8b 100644 > >>--- a/hw/acpi/nvdimm.c > >>+++ b/hw/acpi/nvdimm.c > >>@@ -624,10 +624,29 @@ static void nvdimm_build_acpi_devices(NVDIMMState *state, GSList *device_list, > >> > >> method = aml_method_serialized("NCAL", 4); > >> { > >>+ Aml *ifctx; > >>+ > >> aml_append(method, aml_store(aml_arg(0), aml_name("HDLE"))); > >> aml_append(method, aml_store(aml_arg(1), aml_name("REVS"))); > >> aml_append(method, aml_store(aml_arg(2), aml_name("FUNC"))); > >> > >>+ /* Arg3 is passed as Package and it has one element? */ > >>+ ifctx = aml_if(aml_and(aml_equal(aml_object_type(aml_arg(3)), > >>+ aml_int(4)), > >>+ aml_equal(aml_sizeof(aml_arg(3)), > >>+ aml_int(1)))); > >>+ { > >>+ /* Local0 = Index(Arg3, 0) */ > >>+ aml_append(ifctx, aml_store(aml_index(aml_arg(3), aml_int(0)), > >>+ aml_local(0))); > >>+ /* Local3 = DeRefOf(Local0) */ > >>+ aml_append(ifctx, aml_store(aml_derefof(aml_local(0)), > >>+ aml_local(3))); > >>+ /* ARG3 = Local3 */ > >>+ aml_append(ifctx, aml_store(aml_local(3), aml_name("ARG3"))); > >>+ } > >>+ aml_append(method, ifctx); > >>+ > >> aml_append(method, aml_store(aml_int(NOTIFY_VALUE), aml_name("NOTI"))); > >> > >> aml_append(method, aml_store(aml_name("RLEN"), aml_local(6))); > > > >I commented on this patch on v3. > >It doesn't look like this was addressed. > > > > Ah... I see no one commented this patch ([PATCH v3 26/32] nvdimm: save arg3 for NVDIMM > device _DSM method) on v3. > > Do you mean we need more and better comment to explain arg3? Or anything else? Interesting. I have it in my sent mail file, but it doesn't seem to be on list. I've just resent it, and a couple of other messages that seem to have disappeared into the ether. These are the messages I have for v3: 33587 F To Xiao Guangro Re: [PATCH v3 26/32] nvdimm: save arg3 for NVDIMM device _DSM method 33588 F To Xiao Guangro Re: [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI 33589 F To Xiao Guangro Re: [PATCH v3 23/32] nvdimm: build ACPI NFIT table 33590 F To Xiao Guangro Re: [PATCH v3 00/32] implement vNVDIMM 33597 F To Xiao Guangro Re: [PATCH v3 23/32] nvdimm: build ACPI NFIT table 33598 F To Xiao Guangro Re: [PATCH v3 00/32] implement vNVDIMM 33599 F To Xiao Guangro Re: [PATCH v3 23/32] nvdimm: build ACPI NFIT table -- MST