From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zo52D-00008s-7u for qemu-devel@nongnu.org; Mon, 19 Oct 2015 03:39:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zo529-0005at-76 for qemu-devel@nongnu.org; Mon, 19 Oct 2015 03:39:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47359) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zo529-0005aX-2X for qemu-devel@nongnu.org; Mon, 19 Oct 2015 03:39:05 -0400 Date: Mon, 19 Oct 2015 10:39:00 +0300 From: "Michael S. Tsirkin" Message-ID: <20151019103754-mutt-send-email-mst@redhat.com> References: <1444535584-18220-1-git-send-email-guangrong.xiao@linux.intel.com> <1444535584-18220-23-git-send-email-guangrong.xiao@linux.intel.com> <20151019095612-mutt-send-email-mst@redhat.com> <56249B59.1040103@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56249B59.1040103@linux.intel.com> Subject: Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xiao Guangrong Cc: ehabkost@redhat.com, kvm@vger.kernel.org, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, imammedo@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net On Mon, Oct 19, 2015 at 03:27:21PM +0800, Xiao Guangrong wrote: > >>+ nvdimm_init_memory_state(&pcms->nvdimm_memory, system_memory, machine, > >>+ TARGET_PAGE_SIZE); > >>+ > > > >Shouldn't this be conditional on presence of the nvdimm device? > > > > We will enable hotplug on nvdimm devices in the near future once Linux driver is > ready. I'd keep it here for future development. No, I don't think we should add stuff unconditionally. If not nvdimm, some other flag should indicate user intends to hotplug things. -- MST