From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53213)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kevin@koconnor.net>) id 1Zo8zZ-0005BA-OD
	for qemu-devel@nongnu.org; Mon, 19 Oct 2015 07:52:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kevin@koconnor.net>) id 1Zo8zW-0001p8-GH
	for qemu-devel@nongnu.org; Mon, 19 Oct 2015 07:52:41 -0400
Received: from mail-qk0-f180.google.com ([209.85.220.180]:34457)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kevin@koconnor.net>) id 1Zo8zW-0001or-CI
	for qemu-devel@nongnu.org; Mon, 19 Oct 2015 07:52:38 -0400
Received: by qkfm62 with SMTP id m62so80733141qkf.1
	for <qemu-devel@nongnu.org>; Mon, 19 Oct 2015 04:52:37 -0700 (PDT)
Date: Mon, 19 Oct 2015 07:52:34 -0400
From: Kevin O'Connor <kevin@koconnor.net>
Message-ID: <20151019115234.GA5874@morn.lan>
References: <1445246284-21137-1-git-send-email-kraxel@redhat.com>
	<CAFEAcA_E-W5zvOmwO1ePFF7O2Y+2vVw-ShF2AtSnh90gSUoQyQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAFEAcA_E-W5zvOmwO1ePFF7O2Y+2vVw-ShF2AtSnh90gSUoQyQ@mail.gmail.com>
Subject: Re: [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface,
 add strings via cmdline.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Gerd Hoffmann <kraxel@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>

On Mon, Oct 19, 2015 at 12:12:34PM +0100, Peter Maydell wrote:
> On 19 October 2015 at 10:17, Gerd Hoffmann <kraxel@redhat.com> wrote:
> > ----------------------------------------------------------------
> > fw_cfg: add dma interface, add strings via cmdline.
> >
> > ----------------------------------------------------------------
> 
> Hi. I'm afraid this fails 'make check':
> 
> TEST: tests/fw_cfg-test... (pid=17533)
>   /i386/fw_cfg/signature:                                              OK
>   /i386/fw_cfg/id:                                                     **
> ERROR:/home/petmay01/qemu/tests/fw_cfg-test.c:40:test_fw_cfg_id:
> assertion failed (qfw_cfg_get_u32(fw_cfg, FW_CFG_ID) == 1): (3 == 1)
> FAIL
> 
> (same failure on 64-bit ARM, ppc64be, OSX, 32-bit ARM).
> 
> Windows fails to compile:
> /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c: In function
> ‘fw_cfg_dma_mem_read’:
> /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c:406: warning:
> integer constant is too large for ‘long’ type

I don't have a Windows test environment, but I suspect the following:

#define FW_CFG_DMA_SIGNATURE 0x51454d5520434647 /* "QEMU CFG" */

should be changed to:

#define FW_CFG_DMA_SIGNATURE 0x51454d5520434647ULL /* "QEMU CFG" */

If that sounds right, I'll respin the last patch.

-Kevin