From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58720)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kevin@koconnor.net>) id 1Zo9Ij-0004Ld-Fh
	for qemu-devel@nongnu.org; Mon, 19 Oct 2015 08:12:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kevin@koconnor.net>) id 1Zo9Ig-0006vO-9P
	for qemu-devel@nongnu.org; Mon, 19 Oct 2015 08:12:29 -0400
Received: from mail-qk0-f173.google.com ([209.85.220.173]:36222)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kevin@koconnor.net>) id 1Zo9Ig-0006vK-5g
	for qemu-devel@nongnu.org; Mon, 19 Oct 2015 08:12:26 -0400
Received: by qkca6 with SMTP id a6so7383110qkc.3
	for <qemu-devel@nongnu.org>; Mon, 19 Oct 2015 05:12:25 -0700 (PDT)
Date: Mon, 19 Oct 2015 08:12:22 -0400
From: Kevin O'Connor <kevin@koconnor.net>
Message-ID: <20151019121222.GA7780@morn.lan>
References: <1445246284-21137-1-git-send-email-kraxel@redhat.com>
	<CAFEAcA_E-W5zvOmwO1ePFF7O2Y+2vVw-ShF2AtSnh90gSUoQyQ@mail.gmail.com>
	<20151019115234.GA5874@morn.lan>
	<CAFEAcA9YtY3D+tGVVxtng3PGCe9TKshgh11Zo_QM_9Rvmc597Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAFEAcA9YtY3D+tGVVxtng3PGCe9TKshgh11Zo_QM_9Rvmc597Q@mail.gmail.com>
Subject: Re: [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface,
 add strings via cmdline.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Marc =?iso-8859-1?Q?Mar=ED?= <markmb@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>

On Mon, Oct 19, 2015 at 01:02:41PM +0100, Peter Maydell wrote:
> On 19 October 2015 at 12:52, Kevin O'Connor <kevin@koconnor.net> wrote:
> > On Mon, Oct 19, 2015 at 12:12:34PM +0100, Peter Maydell wrote:
> >> Windows fails to compile:
> >> /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c: In function
> >> ‘fw_cfg_dma_mem_read’:
> >> /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c:406: warning:
> >> integer constant is too large for ‘long’ type
> >
> > I don't have a Windows test environment, but I suspect the following:
> >
> > #define FW_CFG_DMA_SIGNATURE 0x51454d5520434647 /* "QEMU CFG" */
> >
> > should be changed to:
> >
> > #define FW_CFG_DMA_SIGNATURE 0x51454d5520434647ULL /* "QEMU CFG" */
> 
> Yes. All 64 bit constants should have an LL or ULL suffix.

Okay - I'll respin patch 7.

> (The test failure is presumably something different.)

I think the fix for the test failure is to make the test less picky
(it should accept a feature bitmap of either 1 or 3).  But I'll leave
that to Marc or Gerd.

-Kevin