From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kwolf@redhat.com, qemu-block@nongnu.org, jasowang@redhat.com,
qemu-devel@nongnu.org, agraf@suse.de,
Christian Borntraeger <borntraeger@de.ibm.com>,
stefanha@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 3/3] virtio-blk: switch off scsi-passthrough by default
Date: Mon, 19 Oct 2015 14:21:01 +0200 [thread overview]
Message-ID: <20151019142101.5e95ed1f.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <20151019145625-mutt-send-email-mst@redhat.com>
On Mon, 19 Oct 2015 14:57:31 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Mon, Oct 19, 2015 at 01:53:50PM +0200, Cornelia Huck wrote:
> > On Sun, 18 Oct 2015 10:59:59 +0300
> > "Michael S. Tsirkin" <mst@redhat.com> wrote:
> >
> > > On Fri, Oct 16, 2015 at 01:07:28PM +0200, Christian Borntraeger wrote:
> >
> > > > Lets keep this patch as is to have scsi=off as default for virtio 1.0
> > > >
> > > > (some iotests do fail because of this)
> > > >
> > > > Christian
> > >
> > > What fails, exactly?
> >
> > For example, testcase 068 (on s390x, since we default virtio-1 to on):
>
> I see, thanks.
> So it's just the assertion that we have in code that fires.
> Sure, scsi must be off by default before virtio 1 is on.
And -hda always assumes defaults...
next prev parent reply other threads:[~2015-10-19 12:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 10:25 [Qemu-devel] [PATCH v2 0/3] virtio-blk: no scsi-passthrough by default Cornelia Huck
2015-10-16 10:25 ` [Qemu-devel] [PATCH v2 1/3] s390x: include HW_COMPAT_* props Cornelia Huck
2015-10-16 10:30 ` Christian Borntraeger
2015-10-16 10:25 ` [Qemu-devel] [PATCH v2 2/3] ppc/spapr: add 2.4 compat props Cornelia Huck
2015-10-16 10:25 ` [Qemu-devel] [PATCH v2 3/3] virtio-blk: switch off scsi-passthrough by default Cornelia Huck
2015-10-16 10:32 ` Christian Borntraeger
2015-10-16 10:44 ` Cornelia Huck
2015-10-16 11:07 ` Christian Borntraeger
2015-10-18 7:59 ` Michael S. Tsirkin
2015-10-19 11:53 ` Cornelia Huck
2015-10-19 11:57 ` Michael S. Tsirkin
2015-10-19 12:21 ` Cornelia Huck [this message]
2015-10-16 12:40 ` [Qemu-devel] [PATCH v2 0/3] virtio-blk: no " Paolo Bonzini
2015-10-21 10:12 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151019142101.5e95ed1f.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=jasowang@redhat.com \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).