From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54293)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Zo94P-0007kH-Tt
	for qemu-devel@nongnu.org; Mon, 19 Oct 2015 07:57:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Zo94P-0002nJ-2o
	for qemu-devel@nongnu.org; Mon, 19 Oct 2015 07:57:41 -0400
Date: Mon, 19 Oct 2015 14:57:31 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20151019145625-mutt-send-email-mst@redhat.com>
References: <1444991154-79217-1-git-send-email-cornelia.huck@de.ibm.com>
	<1444991154-79217-4-git-send-email-cornelia.huck@de.ibm.com>
	<5620D254.60502@de.ibm.com>
	<20151016124403.2fa55ceb.cornelia.huck@de.ibm.com>
	<5620DA70.1050702@de.ibm.com>
	<20151018105946-mutt-send-email-mst@redhat.com>
	<20151019135350.7bd1dbf5.cornelia.huck@de.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151019135350.7bd1dbf5.cornelia.huck@de.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v2 3/3] virtio-blk: switch off
	scsi-passthrough by default
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: kwolf@redhat.com, qemu-block@nongnu.org, jasowang@redhat.com, qemu-devel@nongnu.org, agraf@suse.de, Christian Borntraeger <borntraeger@de.ibm.com>, stefanha@redhat.com, pbonzini@redhat.com

On Mon, Oct 19, 2015 at 01:53:50PM +0200, Cornelia Huck wrote:
> On Sun, 18 Oct 2015 10:59:59 +0300
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
> 
> > On Fri, Oct 16, 2015 at 01:07:28PM +0200, Christian Borntraeger wrote:
> 
> > > Lets keep this patch as is to have scsi=off as default for virtio 1.0
> > > 
> > > (some iotests do fail because of this)
> > > 
> > > Christian
> > 
> > What fails, exactly?
> 
> For example, testcase 068 (on s390x, since we default virtio-1 to on):

I see, thanks.
So it's just the assertion that we have in code that fires.
Sure, scsi must be off by default before virtio 1 is on.


> --- /data/git/yyy/qemu/tests/qemu-iotests/068.out	2015-03-09 12:32:35.245444052 +0100
> +++ 068.out.bad	2015-10-19 13:48:00.023772655 +0200
> @@ -3,9 +3,8 @@
>  === Saving and reloading a VM state to/from a qcow2 image ===
>  
>  Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=131072
> +qemu-system-s390x: -hda /data/git/yyy/qemu/build/tests/qemu-iotests/scratch/t.qcow2: Please set scsi=off for virtio-blk devices in order to use virtio 1.0
>  QEMU X.Y.Z monitor - type 'help' for more information
> -(qemu) savevm 0
> -(qemu) quit
> +(qemu) qemu-system-s390x: -hda /data/git/yyy/qemu/build/tests/qemu-iotests/scratch/t.qcow2: Please set scsi=off for virtio-blk devices in order to use virtio 1.0
>  QEMU X.Y.Z monitor - type 'help' for more information
> -(qemu) quit
> -*** done
> +(qemu) *** done